search

fferroni / PointPillars

Point Pillars 3D detection network implementation in Tensorflow
GNU General Public License v3.0
47 stars 17 forks source link

Inconsistent units of bounding box yaws #10

Open RM-Costa opened 4 years ago

RM-Costa commented 4 years ago

In config.py, the yaws are written in radians, but in point_pillars_test.py they're in degrees.

Is this a bug or am I missing something ?

tyagi-iiitv commented 4 years ago

This is the updated version of this repo: https://github.com/tyagi-iiitv/PointPillars.

RM-Costa commented 4 years ago

This is the updated version of this repo: https://github.com/tyagi-iiitv/PointPillars.

Thanks for the answer, but I still see the same issue in your fork. In config.py the anchor boxes orientation is in radians, but in point_pillars_test.py the yaws are in degrees. These values are used in the IoU computation, which uses std::cos and std::sin operations, so the units should be all in radians for the code to work properly.

tyagi-iiitv commented 4 years ago

I've added this as an issue on my repo, I'll verify and work on it. In the meantime, if you want to submit a PR to my repo, go ahead with that. Anyway, I'll let you know when this is fixed.