Closed chcg closed 2 years ago
Thanks for the PR.
I have tried the fix for the Makefile and it worked. Thanks a lot for that!
Although I am not a big fan of adding very different things in one PR, thanks for adding the ARM64 build.
I have added the ARM64 compilers to Visual Studio and that seems to work. But I have no way to check if that works. I don't have a Windows ARM64 device.
And I have a couple of questions:
Why have you added the gh action dependabot
?
The project doesn't have any dependencies it can check as far as I am aware of. The only external dependency are SQLite and the NPP headers. But all those files are just copied into the repository. So I don't see any need to add dependabot.
Why is the MinGW-build added to msbuild.yml
and not added as a separate mingw-build.yml
?
And looking at the YML the BITS=${{ matrix.build_platform }}
is not gonna work. I would suggest to change it to something like this (note that I haven't tested this):
- name: build x86
if: matrix.build_platform == '32'
run: make ARCH=i686-w64-mingw32
- name: build x64
if: matrix.build_platform == '64'
run: make ARCH=x86_64-w64-mingw32
Apart from the small change I requested in the Makefile the PR looks good to me.
adapted gh action and makefile to your suggestion
Thanks again for the PR