search

ffes / nppsnippets

Code Snippets plugin for Notepad++
https://www.fesevur.com/nppsnippets
GNU General Public License v2.0
71 stars 12 forks source link

broken view after NPP 8.4.3 #45

Closed Deadooshka closed 2 years ago

Deadooshka commented 2 years ago

Wrong sub-window style and scroll bugs.

ffes commented 2 years ago

image

Works for me

Deadooshka commented 2 years ago

snippet_broken Dark mode seems ok, but normal mode is displayed with wrong background color and distorted scrolling.

ffes commented 2 years ago

That is very strange indeed. Not sure if it is my plugin or if it a bug in n++ itself. I need to investigate it further.

emulite commented 2 years ago

Having the same issue. When change from editing php to js and the other way, it seems to 'overprint', snippets error after changing language

Also in normal mode the drop-down menu has a black background so cannot see options (black on black) untill you move cursor down them snippets drop down Using NPP 8.4.4 on windows 10

kiwichick888 commented 2 years ago

I am experiencing the same problem with the black menu and the 'overprint'. Currently using the latest Npp v8.4.4. Even with a clean install and only Snippets added this is present so it doesn't seem to be related to any non-default plugins.

ffes commented 2 years ago

I am AFK now, using that app on my phone to react.

I have looked at it shortly before I left and saw that there was a change in N++ 8.4.3 to make plugins automatically adopt the dark theme. There is no mention that plugins devs need to change their plugins in any way to support this. And it works fine in my tags plugin. But that is a tree and this plugin uses a list which might be exactly the problem.

Therefore I think (without having the possibility to really investigate) it is an upstream problem. Something in N++ had changed and it broke this plugin in the light theme because it uses a docked list.

I think this won't be fixable for me. Someone has to reports this upstream, and I can't do that in the coming weeks.

kiwichick888 commented 2 years ago

a change in N++ 8.4.3 to make plugins automatically adopt the dark theme

According to information given on the Npp community site, v8.4.1 provided a new API call so that plugins can find out whether Notepad++ is in Dark Mode. It didn't say the new API would make plugins automatically adopt Dark Mode. So that may make a difference to how you approach a potential fix. If not, hopefully someone will report it upstream. I absolutely love Snippets and would hate to have to do without it.

kiwichick888 commented 2 years ago

I am AFK now, using that app on my phone to react.

I have looked at it shortly before I left and saw that there was a change in N++ 8.4.3 to make plugins automatically adopt the dark theme. There is no mention that plugins devs need to change their plugins in any way to support this. And it works fine in my tags plugin. But that is a tree and this plugin uses a list which might be exactly the problem.

Therefore I think (without having the possibility to really investigate) it is an upstream problem. Something in N++ had changed and it broke this plugin in the light theme because it uses a docked list.

I think this won't be fixable for me. Someone has to reports this upstream, and I can't do that in the coming weeks.

I have noticed that not all my Snippets libraries have the overprint problem. Some load fine, some overprint. It's very strange. However, I really hope you find a solution for this because Snippets is my absolute favourite Npp plugin and I use it every day.

ffes commented 2 years ago

I just reported it upstream: https://github.com/notepad-plus-plus/notepad-plus-plus/issues/12007

kiwichick888 commented 2 years ago

I just reported it upstream: notepad-plus-plus/notepad-plus-plus#12007

Excellent! Hopefully they can provide a solution.

kiwichick888 commented 2 years ago

I just reported it upstream: notepad-plus-plus/notepad-plus-plus#12007

Hey there, I've just checked that link and there's been a workaround suggested. Have you tried it?

ffes commented 2 years ago

Yes, I've tried both, but so far it didn't help.

But to test it properly I need to update ALL the N++ header files and for that I need to create a new toolbar icon because the call to add the icon to the toolbar has changed a while ago as well to support dark mode icons. So that is a bit more work and life is quite busy at the moment.

kiwichick888 commented 2 years ago

All good, just checking you'd seen it. Whenever you find the time to deal with it will be great. Thanks.

Deadooshka commented 2 years ago

as a workaround we can copy stylers.xml into themes\DarkModeDefault.xml and set customized colors in the preferences/dark mode.

warbirdphotog commented 2 years ago

I use Snippets almost daily, such a great tool. But I've been having the same issues as others on here, when I scroll it blackens out the entire list of tags. On mouse over or minimizing to taskbar and then bringing Notepad++ back up it restores them, but can scrolling will turn it back to black. I'm running the latest version of both Notepad++ and Snippets.

ffes commented 2 years ago

Today I release v1.7.1 which fixes this issue https://www.fesevur.com/2022/10/04/nppsnippets-171

If you don't want to wait for the plugin manager of N++ to get this version, download the zip you need, extract NppSnippets.dll and replace the one on your system.

kiwichick888 commented 2 years ago

Thank you so much!

On Wed, 5 Oct 2022 at 09:49, Frank Fesevur @.***> wrote:

Today I release v1.7.1 which fixes this issue https://www.fesevur.com/2022/10/04/nppsnippets-171

If you don't want to wait for the plugin manager of N++ to get this version, download the zip you need, extract NppSnippets.dll and replace the one on your system.

— Reply to this email directly, view it on GitHub https://github.com/ffes/nppsnippets/issues/45#issuecomment-1267560877, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSL6HMFE3SJCBFYJA2UMLLWBSJ4LANCNFSM53ZMEY5A . You are receiving this because you commented.Message ID: @.***>

kiwichick888 commented 2 years ago

In this new version the 'Show Toolbox Icon' doesn't appear to be working. The button doesn't appear on the toolbar.

On Fri, 7 Oct 2022 at 11:27, deleelee @.***> wrote:

Thank you so much!

On Wed, 5 Oct 2022 at 09:49, Frank Fesevur @.***> wrote:

Today I release v1.7.1 which fixes this issue https://www.fesevur.com/2022/10/04/nppsnippets-171

If you don't want to wait for the plugin manager of N++ to get this version, download the zip you need, extract NppSnippets.dll and replace the one on your system.

— Reply to this email directly, view it on GitHub https://github.com/ffes/nppsnippets/issues/45#issuecomment-1267560877, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSL6HMFE3SJCBFYJA2UMLLWBSJ4LANCNFSM53ZMEY5A . You are receiving this because you commented.Message ID: @.***>

ffes commented 2 years ago

In this new version the 'Show Toolbox Icon' doesn't appear to be working. The button doesn't appear on the toolbar.

Haven't tested it myself yet (always hide the icon anyway), but could you please file a separate issue for this. This is not directly related to this issue, which is about problems redraw problems with the list.

kiwichick888 commented 2 years ago

Oops sorry about that. I've filed a new issue.

On Wed, 12 Oct 2022 at 00:57, Frank Fesevur @.***> wrote:

In this new version the 'Show Toolbox Icon' doesn't appear to be working. The button doesn't appear on the toolbar.

Haven't tested it myself yet (always hide the icon anyway), but could you please file a separate issue for this. This is not directly related to this issue, which is about problems redraw problems with the list.

— Reply to this email directly, view it on GitHub https://github.com/ffes/nppsnippets/issues/45#issuecomment-1274567664, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSL6HNTBZCV2I27UUSBS6TWCVI3ZANCNFSM53ZMEY5A . You are receiving this because you commented.Message ID: @.***>

ffes commented 2 years ago

With the release of N++ 8.4.7, the new version of the plugin is available in the Plugin Admin

Deadooshka commented 1 year ago

Still white colored gui controls in N++ with dark mode. Appears in Win10 but not Win7.

ffes commented 1 year ago

The problem you reported was that it didn't work in light mode. To fix that we had to disable the (broken) mode in N++ itself that automatically adjusts plugins to follow the theme. As a result of that the dark mode doesn't look that great anymore. As long as https://github.com/notepad-plus-plus/notepad-plus-plus/issues/12007 is not fixed the layout of this plugin will remain as it is. There is not much I can do about it. This is an upstream problem.