fff-rs / juice

The Hacker's Machine Learning Engine
1.11k stars 76 forks source link

Simplify new_rnn_config() by only passing input size, not the full tensor #195

Closed hweom closed 1 year ago

hweom commented 1 year ago

What does this PR accomplish?

Changes proposed by this PR:

Replace the src argument to new_rnn_config() with just scalar input size as it's the only information the function needs.

Notes to reviewer:

This is in preparation for reimplementation of RNN layer in new arch.

📜 Checklist

hweom commented 1 year ago

Can you clarify? Why would we want to know the specific input data at the point of network construction?

drahnr commented 1 year ago

It's not the input dat, but rather the dimensionality encoded in the container, that a shared tensor really is. And iirc the container is empty by default

drahnr commented 1 year ago

I agree from an API perspective the current state is incoherent