search

fff-rs / juice

The Hacker's Machine Learning Engine
1.1k stars 77 forks source link

Move `juice-examples` out from `juice` repo #45

Open andreytkachenko opened 5 years ago

andreytkachenko commented 5 years ago

Because cargo does not supports workspaces inside workspace, but I do want to add some more example networks (besides MNIST)

drahnr commented 5 years ago

Are you sure, removing was primarily motivated due to it's old hyper-tls and thus openssl requirement. I observed no other errors during build.

What cargo/rustc version are you using?

andreytkachenko commented 5 years ago

rustc --version: 1.37.0-nightly (5d8f59f4b 2019-06-04)

It works fine, I've fixed issues in #46. My concerns is that, I would like to have several different examples (each one as a separate crate) under examples folder. May be it is good to have examples folder inside juice itself showing some basic examples (i.e. MNIST), but also separate repo - examples of models (AlexNet, Yolo, MobileNet, Wave-U-Net, etc.)

drahnr commented 5 years ago

I think that's the best approach for the time being. We could still discussing maybe example just holds a set of examples. I'd like to keep at least one in there to assure a working demo.

drahnr commented 4 years ago

Another approach would be to use the juice-examples as a nested workspace which contains all examples as individual projects. What do you think?

lissahyacinth commented 4 years ago

Individual binaries is more common for this type of data science library - it's expected that users will copy a binary in full and modify it to suit their needs before writing something from scratch, and keeping each example independent would help towards that.

drahnr commented 4 years ago

Alright, so a nested workspace would work 👏 - possibly with overwrites to work with the juice present in the repo usable for integration tests too

drahnr commented 3 years ago

Conclusion was to automate export of juice examples on release via CI to separate repositories, which work with the crates.io upstream. Also note that currently cargo does not support nested workspaces.