search

fffilo / gnome-radio

Listen to an internet radio stream
8 stars 2 forks source link

Crash after stop & play #5

Open Prominence opened 6 years ago

Prominence commented 6 years ago

After click on 'stop' button and then click on 'play' button title & button state wasn't changed (music is playing, but button label near the 'play' button is 'STOPPED'). After several attemts to stop & play it crashes. Some log entries:

JS ERROR: Exception in callback for signal: click: TypeError: this.player is null
                                                 Indicator<._handle_menu_item_channel@/home/<user>/.local/share/gnome-shell/extensions/gnome-radio@gnome-shell-exstensions.fffilo.github.com/ui.js:263:9
                                                 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                                 _emit@resource:///org/gnome/gjs/modules/signals.js:126:27
                                                 ChannelMenu<._handle_menu_item@/home/<user>/.local/share/gnome-shell/extensions/gnome-radio@gnome-shell-exstensions.fffilo.github.com/ui.js:530:9
                                                 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                                 ChannelMenu<.reload/<@/home/<user>/.local/share/gnome-shell/extensions/gnome-radio@gnome-shell-exstensions.fffilo.github.com/ui.js:593:25
                                                 _emit@resource:///org/gnome/gjs/modules/signals.js:126:27
                                                 PopupBaseMenuItem<.activate@resource:///org/gnome/shell/ui/popupMenu.js:166:9
                                                 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                                 PopupBaseMenuItem<._onButtonReleaseEvent@resource:///org/gnome/shell/ui/popupMenu.js:127:9
                                                 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22

 JS ERROR: Exception in callback for signal: click: TypeError: this.player is null
                                                 Indicator<._handle_menu_item_channel@/home/<user>/.local/share/gnome-shell/extensions/gnome-radio@gnome-shell-exstensions.fffilo.github.com/ui.js:263:9
                                                 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                                 _emit@resource:///org/gnome/gjs/modules/signals.js:126:27
                                                 ChannelMenu<._handle_menu_item@/home/<user>/.local/share/gnome-shell/extensions/gnome-radio@gnome-shell-exstensions.fffilo.github.com/ui.js:530:9
                                                 wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                                 ChannelMenu<.reload/<@/home/<user>/.local/share/gnome-shell/extensions/gnome-radio@gnome-shell-exstensions.fffilo.github.com/ui.js:593:25

Arch Linux x64, Gnome 3.26.2

canibal commented 6 years ago

I also have this issue on Gnome 3.26.2 as packaged with Ubuntu 17.10.

Playback also stops when I try to change to any other channel than the one I initially selected. And clicking Play Button continues playback from original station. I am unable to choose a different one without restarting the extension.

JoergPalmer commented 6 years ago

Same here (Gnome v3.28.2 on openSUSE Tumbleweed)

I managed to change the station list to my liking, but not able to switch stations. Would be nice if switching stations were possible.

Other than this ... very nice extension! Thank you :-)