search

fffunction / backstop-crawl

🕷 Crawls a site to generate a backstopjs config file with scenarios pre-populated
38 stars 18 forks source link

Allow a default configuration file #23

Closed ataylorme closed 6 years ago

ataylorme commented 7 years ago

Addresses #6

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-4.3%) to 95.745% when pulling 4c7cb9fbc3eeff4c34da52c775e0cdcd995d9373 on ataylorme:default-config into ffaad21d42b27eda45e075801c9d03ff46d37829 on fffunction:master.

ataylorme commented 6 years ago

@danreeves pushed some updates and tested this locally - it is working well for me.

Seems like some ES6 syntax, such as const currentScenario = {...defaultScenario}; to clone an object, are failing tests on the older versions of Node.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-3.3%) to 96.721% when pulling 4f726a4744c26cf1b14f39e3b2566a71be7b0f2a on ataylorme:default-config into ffaad21d42b27eda45e075801c9d03ff46d37829 on fffunction:master.

ataylorme commented 6 years ago

Looks like valid-url doesn't like localhost or non-standard ports.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-1.6%) to 98.361% when pulling 9757d62ce910b8645321f46012865e02dc3d75f6 on ataylorme:default-config into ffaad21d42b27eda45e075801c9d03ff46d37829 on fffunction:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling db64d049c1e082332381d4f739cca6be0f60963a on ataylorme:default-config into ffaad21d42b27eda45e075801c9d03ff46d37829 on fffunction:master.

ataylorme commented 6 years ago

@danreeves added some tests and fixed the LTS node issue. Should be good for a final review!

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1573f63c7b7b2e7d23d733139d69506adbcba0fa on ataylorme:default-config into ffaad21d42b27eda45e075801c9d03ff46d37829 on fffunction:master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 1573f63c7b7b2e7d23d733139d69506adbcba0fa on ataylorme:default-config into ffaad21d42b27eda45e075801c9d03ff46d37829 on fffunction:master.

danreeves commented 6 years ago

I'm going to test this out locally and make a release later on today

ataylorme commented 6 years ago

Sounds good - if you need anything else from me just let me know. Thank you for creating the tool, to begin with, helping with suggestions and spending time testing. I'm looking forward to using this for upcoming projects!

danreeves commented 6 years ago

Merged and released. Thanks again!

ataylorme commented 6 years ago

Awesome - thanks @danreeves!