Closed alexeymorozov closed 2 years ago
Looks good! :+1:
Hi @davispuh , would the PR be merged soon? We're waiting for it in metanorma/packed-mn#142 . Thanks!
Hi @davispuh , would the PR be merged soon? We're waiting for it in metanorma/packed-mn#142 . Thanks!
Hi, while I have permissions to merge, I don't consider myself as maintainer :D So I would want that someone else takes a look too and I've no idea who even can publish releases. Maybe @enebo
Thank you @davispuh ! I believe @enebo and @stakach are the releasers. https://rubygems.org/gems/ffi-compiler
Look forward to have this merged soon!
Pinging @enebo and @stakach for a review. Thanks!
Following up on this PR, pinging @enebo @stakach
I just merged.
Thank you @davispuh ! Now the challenge is on whether a new release is possible... Seems like only @enebo and @stakach can release?
Yeah, I don't have permissions on RubyGems so can't. But you can just use my fork ffi-compiler2
Thank you @davispuh , we are actually already using your ffi-compiler2
fork 😉
Would it be possible to update your fork to reflect this change? Thanks!
Actually this was already merged to ffi-compiler2
in 2020 (https://github.com/davispuh/ffi-compiler/pull/2), thanks!
The following method takes any file matching any pattern provided with no intentional order.
In particular on the
x86_64
Windows it choosesi386-windows/libmspack.dll
instead ofx86_64-windows/libmspack.dll
.This PR fixes the issue. What do you think?
Follows https://github.com/davispuh/ffi-compiler/pull/2