search

ffi / ffi-compiler

Apache License 2.0
32 stars 10 forks source link

Make MultiFileTask ignore the scope like FileTask #27

Closed ntkme closed 6 months ago

ntkme commented 6 months ago

Fixes #26.

The issue is that Rake::FileTask ignores the scope when being created under a rake namespace: https://github.com/ruby/rake/blob/15e936c87aca9789b6f7a2a0c91566f972720ece/lib/rake/file_task.rb#L50-L56

However, FFI::Compiler::MultiFileTask honors with the namespace, thus the task would be created with a different fully qualified name, and breaks existing code.

davispuh commented 6 months ago

Funny lol looks like we both researched this at same time and came up with exactly same solution at same time :smile:

Looks like I was faster by few seconds but still thanks for digging into it! It took me a while to understand what's actually happening and figuring out fix.