fflewddur / tophat

View CPU, memory, disk, and network activity in the GNOME top bar.
https://extensions.gnome.org/extension/5219/tophat/
GNU General Public License v3.0
349 stars 26 forks source link

App icons (VLC, Remmina etc) in top panel split CPU and Memory display #25

Closed ijefferies closed 2 years ago

ijefferies commented 2 years ago

Everything looks fine after startup (see below). image

If you now run an app that uses the Gnome top panel, the app icon splits the Tophat CPU and Memory display (see below). At least VLC and Remmina have this effect on the display. image

Expected behaviour is that the Tophat usage displays remaining together. If you subsequently disable/enable a Gnome extension (seems like doesn't matter which one), the icon and display order is corrected (see below). image

This bug can be reproduced every time on this system. image

fflewddur commented 2 years ago

Thanks for the report! I'd love to use a single widget for all of the indicators, which would prevent this problem, but I haven't figured out how to do that while also having separate drop-downs with process/memory/network details for each indicator. Once I or another contributor can get that working, I think it will resolve this issue.

ijefferies commented 2 years ago

That's a shame, hopefully you (or someone) can come up with a solution in the near future. Aside from this bug, it's a great extension (and looks a lot more modern than System-Monitor_next).

ijefferies commented 2 years ago

OK, how about this. Include an option to place all app widgets to the right of the centre date/time widget (rather than right side).

Although this won't fix the problem of widgets splitting, the chance of additional widgets being added to the centre panel mid session is highly unlikely so it would have the effect of keeping all widgets together. What do you think, is this an easy addition to the code?

fflewddur commented 2 years ago

I'm not sure if this would be easy (or even possible--I'm learning a lot about the modern GNOME shell by building this extension, I haven't done much with GNOME since the 2.x days), but I'm open to a PR adding this option. Long term, I'd still like to get all of the indicators into a single top bar container.

fflewddur commented 2 years ago

I tracked this down to the appindicator shell extension: it inserts itself after the first item in the panel, instead of the the start of panel box. The above PR should fix this behavior if it gets merged.

jvalrog commented 2 years ago

Thanks for the report! I'd love to use a single widget for all of the indicators, which would prevent this problem, but I haven't figured out how to do that while also having separate drop-downs with process/memory/network details for each indicator. Once I or another contributor can get that working, I think it will resolve this issue.

My 2 cents. You could use a single drop-down where you display what the user has enabled, separated by a line, like this mockup:

image

That way you can have a single widget instead of 3. They should share the same arrangement though so all graphics are lined up.

ijefferies commented 2 years ago

Just tried again, works a treat. Thanks for fixing.