Wrong branch name in Docker file: 'docker build' fails

ffmpeginteropx / FFmpegInteropX

FFmpeg decoding library for Windows 10 UWP and WinUI 3 Apps

Apache License 2.0

212 stars 53 forks source link

Wrong branch name in Docker file: 'docker build' fails #276

Closed jdembdr closed 2 years ago

jdembdr commented 2 years ago

Hi, During the image creation, the specified branch for git clone in Dockerfile is release-1.0, but these branch does not exist.

RUN git clone https://github.com/ffmpeginteropx/FFmpegInteropX.git --recursive -branch release-1.0

following lines fix the problem for me:

RUN git clone https://github.com/ffmpeginteropx/FFmpegInteropX.git --recursive 

# Install build tools
RUN cd FFmpegInteropX `
    && git checkout v1.0.0 `
    && powershell .\Build\InstallTools.ps1 `
    && rd /S /Q C:\$Recycle.Bin

tks,

lukasf commented 2 years ago

You are right, I forgot to update the dockerfile when bringing this to master branch. I updated the dockerfile on master now.