search

ffmpeginteropx / FFmpegInteropX

FFmpeg decoding library for Windows 10 UWP and WinUI 3 Apps
Apache License 2.0
205 stars 52 forks source link

Improve subtitle character encoding detection #369

Closed lukasf closed 9 months ago

lukasf commented 10 months ago

This is to solve #367

I also added conversion from UTF16BE/LE to UTF8, if we detect that encoding (never ever seen that on a sub, but anyways).

softworkz commented 10 months ago

While you're at it: I noticed that in case when the subtitle stream is empty (length=0), it throws an exception.

I think it didn't do that before, could that be?

I just noticed it from the C# side and didn't follow any further.

lukasf commented 10 months ago

We throw an exception if no subtitle track was added. So that's expected when you pass a blank empty file (or a valid media file which does not have subs).

softworkz commented 10 months ago

We throw an exception if no subtitle track was added. So that's expected when you pass a blank empty file (or a valid media file which does not have subs).

Okay.

lukasf commented 9 months ago

I think this is good to merge, right?

brabebhin commented 9 months ago

Yes.