search

ffmpeginteropx / FFmpegInteropX

FFmpeg decoding library for Windows 10 UWP and WinUI 3 Apps
Apache License 2.0
205 stars 52 forks source link

Fix audioeffects with new ffmpeg channel layout APIs #435

Closed lukasf closed 1 week ago

lukasf commented 2 weeks ago

This fixes audio effects on latest winui branch. When switching to new channel layouts, they renamed all the fields from channel_layout to ch_layout, except for this one.

Thanks @sakib1361 for reporting!

brabebhin commented 2 weeks ago

PR points to master.

lukasf commented 2 weeks ago

Right, thanks @brabebhin

brabebhin commented 2 weeks ago

Approved.

With the cs uwp sample there's no crash on winUI-build branch but the effects do not apply. This is how it got past the first round of tests. We should pick a more obvious test filter😂

sakib1361 commented 1 day ago

@lukasf Thanks for the fix. Hope it comes to nuget package soon.