search

ffmpegwasm / ffmpeg.wasm

FFmpeg for browser, powered by WebAssembly
https://ffmpegwasm.netlify.app
MIT License
13.49k stars 775 forks source link

Providing webpackIgnore is crucial for a successful Webpack build. #613

Closed baszczewski closed 8 months ago

baszczewski commented 8 months ago

Without this change, I've got an error here:

Compiled with problems: × WARNING in ./node_modules/@ffmpeg/ffmpeg/dist/esm/worker.js 20:39-21:35 Critical dependency: the request of a dependency is an expression

netlify[bot] commented 8 months ago

Deploy Preview for ffmpegwasm canceled.

Name Link
Latest commit b4e96eeccb519432996de7f20fe5344c0188f7bb
Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/6532199921570b000843014a
jeromewu commented 8 months ago

Thanks for the contribution! I think this is a great fix for many people.

KritR commented 6 months ago

Hey sorry to bother here, any plans for a release with this fix? @jeromewu.

incidentist commented 6 months ago

This PR was merged, but was overwritten in this commit, so it didn't go out in the latest release and never will unless it's re-done: https://github.com/ffmpegwasm/ffmpeg.wasm/commit/083397a6020279e59c1051ed04e139f67a28525f

jeromewu commented 6 months ago

This PR causes this error in the official website, thus temporary reverted in master branch image

jeromewu commented 6 months ago

This issue only happens in production mode, ex:

npm run build
npm run serve