ffmpegwasm / ffmpeg.wasm

FFmpeg for browser, powered by WebAssembly
https://ffmpegwasm.netlify.app
MIT License
13.49k stars 776 forks source link

update libvpx & libwebp to latest releases #629

Closed jzern closed 6 months ago

jzern commented 7 months ago

libvpx: 1.13.1 libwebp: 1.3.2

netlify[bot] commented 7 months ago

Deploy Preview for ffmpegwasm ready!

Name Link
Latest commit 1d72f8d814ab971ac1fc90ed0e74cececcdb5b62
Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/6580bffd086f9700085783a1
Deploy Preview https://deploy-preview-629--ffmpegwasm.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jzern commented 7 months ago

I have a couple of questions unrelated to this commit:

  1. Is there any interest in adding support for libaom (AV1 / AVIF encoding?)
  2. libvpx uses --target=generic-gnu was there an issue building the x86 optimizations for
jeromewu commented 6 months ago

@jzern Thanks for the contribution, but after testing I found that there is no problem to upgrade libvpx to 1.13.1, but upgrading libwebp to 1.2.0+ results in the error below: image

Thus, I think libwebp 1.2.1+ is not compatible with ffmpeg n5.1.3 / n5.1.4.

May I trouble you to update this PR to upgrade libvpx to 1.13.1 and libwebp to 1.2.0? Thanks.

jzern commented 6 months ago

Thanks for the contribution, but after testing I found that there is no problem to upgrade libvpx to 1.13.1, but upgrading libwebp to 1.2.0+ results in the error below:

WebPAnimEncoder* come from libwebpmux; see ffmpeg's configure check 1. The motivation behind this change is to ensure the snapshot has all available bug and security fixes. An option is to update to a commit on the 1.2.0 release branch, but I'd prefer is this can get fixed so this code base has the latest code.

How can I reproduce the issue?

jzern commented 6 months ago

I see the issue using make dev. Maybe there was an issue in the ffmpeg snapshot you are using. v1.2.0-8-g20ceff7e is a fallback on the 1.2.0 branch.

jzern commented 6 months ago

@jeromewu this should be fixed now. I didn't notice in my original change that the libs are explicitly named in Dockerfile and passed ffmpeg-wasm.sh.

jeromewu commented 6 months ago

Thanks for your contribution!