search

ffmpegwasm / ffmpeg.wasm

FFmpeg for browser, powered by WebAssembly
https://ffmpegwasm.netlify.app
MIT License
13.47k stars 776 forks source link

Add option to pass worker url to the ffmpeg.load #639

Closed kisel4363 closed 6 months ago

netlify[bot] commented 7 months ago

Deploy Preview for ffmpegwasm canceled.

Name Link
Latest commit 9c6620ab0ded62a2858529a53a9dafe84440864a
Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/656d0187dd6b6e000897003c
PaulieScanlon commented 7 months ago

🥳

jeromewu commented 6 months ago

@kisel4363 I think this PR doesn't make sense as the workerURL in the config is for ffmpeg-core.worker.js, so passing the worker here doesn't work.

Can you share more context of your use case here?

PaulieScanlon commented 6 months ago

Hey @jeromewu. Here's the issue I opened in the Remix repo.

https://github.com/remix-run/remix/issues/8215

Not sure if this is a Remix issue or an ffmpeg/WASM issue.

Would you be able to take a look at the reproduction repo I created (linked in the above issue)... I'm kinda stuck.

jeromewu commented 6 months ago

I have no experience in remix and thus don't know how to help. You can try 0.12.8 and see if assigning a custom classWorkerURL helps.

dchristensen commented 6 months ago

@jeromewu The fix from #652 does not seem to be in the ESM module for 0.12.8: https://unpkg.com/browse/@ffmpeg/ffmpeg@0.12.8/dist/esm/classes.js#L102

jeromewu commented 6 months ago

@dchristensen Fixed in 0.12.9