search

ffmpegwasm / ffmpeg.wasm

FFmpeg for browser, powered by WebAssembly
https://ffmpegwasm.netlify.app
MIT License
13.47k stars 776 forks source link

Fix worker coreURL for ESM #657

Closed dchristensen closed 4 months ago

dchristensen commented 6 months ago

Currently when loading the core module from the ESM worker if coreURL is not specified in the config, the default unpkg UMD path is used instead of the ESM path. Basically _coreURL is always set inside the try so it is never falsey in the catch, therefore the esm replacement never occurs.

I believe this is what #602 was attempting to fix as well, this is a bit simpler fix.

netlify[bot] commented 6 months ago

Deploy Preview for ffmpegwasm canceled.

Name Link
Latest commit 25e2bb6cd05a773de8e1f097b10eb0d8551ffd4c
Latest deploy log https://app.netlify.com/sites/ffmpegwasm/deploys/658fca606787b00008f8a494
jeromewu commented 4 months ago

Thanks for the contribution!