Don't assume "hostname" is present

ffnord / ffmap-backend

THIS PROJECT DOESN'T HAVE A MAINTAINER!

Other

20 stars 59 forks source link

Don't assume "hostname" is present #64

Closed kpcyrd closed 8 years ago

kpcyrd commented 8 years ago

https://forum.freifunk.net/t/meshviewer-zeigt-ploetzlich-typeerror/6956

tcatm commented 8 years ago

I don't think setting "unnamed" as a default is sane. Could this work without a hostname at all?

kpcyrd commented 8 years ago

Leaving name unset would be another way, but I think this would potentially break a lot of other things.

tcatm commented 8 years ago

A quick solution may be to ignore such nodes (as is done for nodes with bogus coordinate information).

mweinelt commented 8 years ago

I'm not sure such a generic try/except is necessary, we're talking about the hostname in this pull request only, aren't we? Also: You should probably rebase your code on top of HEAD, instead of dragging along 10 other commits from other people.

kpcyrd commented 8 years ago

@mweinelt maybe stop rewinding head then? master was pointing to c2e21b4 at the point I've forked the repo. 275d6e4 was my original proposal to fix the bug, feel free to PR a better solution.