search

ffnord / ffmap-backend

THIS PROJECT DOESN'T HAVE A MAINTAINER!
Other
20 stars 59 forks source link

Fixes a type error (nodes is no dict any longer, error was: Attribute… #68

Closed mruettgers closed 8 years ago

mruettgers commented 8 years ago

…Error: 'list' object has no attribute 'items')

Solves the following error when using --with-rrd option:

Traceback (most recent call last): File "./backend.py", line 205, in main(options) File "./backend.py", line 162, in main rrd.update_database(nodedb['nodes']) File "/opt/freifunk/ffmap-backend-test/lib/rrddb.py", line 32, in update_database lambda d: d[1]['flags']['online'], nodes.items()))

jplitza commented 8 years ago

This doesn't call NodeRRD.update() anymore when the node is offline. That's bad, because the RRD contains a field that should plot exactly that: When was the node offline? If the RRD simply isn't updated if the node is offline, it will never appear as offline due to interpolation of the surrounding online-values. Also, it wouldn't be distinguishable if the node is offline of the backend simply didn't run.