ffnord / ffmap-backend

THIS PROJECT DOESN'T HAVE A MAINTAINER!
Other
20 stars 56 forks source link

y-labels unreadable on node with many clients #84

Closed ecsv closed 8 years ago

ecsv commented 8 years ago

It was noticed on the meshviewer installation of Freifunk Chemnitz that the nodes with a large number of clients have overlapping y-labels. This was caused by the '-y 1:1' setting for rrdtool

tietz_default_settings

This made them remove this setting. The result looked fine for these nodes.

tietz

But nodes with a smaller number of nodes started to have fractional part

test

This freaked out some people and thus I've started to play around with the setting. @simonwunderlich looked at them and told me that '-Y' seemed to look better to him. Here are the previous examples with '-Y' instead of '-y 1:1'

tietz_better_settings test_better_settings

It is far from perfect but at least doesn't seem to discriminate any of my examples in favor of the other one. Maybe '-Y' could replace '-y 1:1' in lib/NodeRRD.py. But I would like to get more opinions (or better solutions) before a pull request is made.


@ambassador86 @deusama This seems to be relevant for you because it is about your server

jplitza commented 8 years ago

Sounds good to me. For the sake of completeness, here's what rrdgraph(1) has to say about -Y:

Place the Y grid dynamically based on the graph's Y range. The algorithm ensures that you always have a grid, that there are enough but not too many grid lines, and that the grid is metric. That is the grid lines are placed every 1, 2, 5 or 10 units. This parameter will also ensure that you get enough decimals displayed even if your graph goes from 69.998 to 70.001. (contributed by Sasha Mikheev).

jplitza commented 8 years ago

I merged the corresponding part from #86, thus closing.