search

ffnord / ffmap-d3

Deprecated and superseded by http://draic.info/meshviewer
24 stars 41 forks source link

Refactor gpsbutton #80

Closed johnyb closed 10 years ago

johnyb commented 10 years ago

just a little polishing of the gpsbutton. Works a little better now and even fixes #66.

Any comments welcome.

johnyb commented 10 years ago

thanks @tcatm for pointing out the trick with classList instead of handling this manually.

Also adjusted ' and " to match the rest of the file

rubo77 commented 10 years ago

It would be nice, if there would stay a new pointer at the position, where you clicked on the map after you close the geocoords popup, but that would be a new issue i guess

johnyb commented 10 years ago

@rubo77 yeah, let me get back on that, later. I'll keep in mind your suggestion. May be, first click adds a new node to the graph and you can still drag it around until the popup is closed. Would need some refactoring of the popup, though. (I don't like a popup very much, anyway ;)) But yes, that's something for later.