Closed rubo77 closed 9 years ago
You can test this with the branch uses the branch https://github.com/rubo77/ffnord-example/commits/multiple_fastd
This looks pretty good to me, but as this is not automaticly mergeable, i would need to check the "why" first. If i found why, I'll tell you to resolf the conflicts. I am eager to merge this. Any other oppinions?
Also: can you please stagg the commits into two or three?
I merged all commits into one. You can still see the old single commits here: https://github.com/rubo77/ffnord-puppet-gateway/tree/multi_fastd_dev
Bevor man diese änderung auf einem Gateway ausrollt muss man natürlich nun dort einiges anpassen:
"fastd_${mesh_interface}"
statt "fastd_${mesh_code}"
checkenbitte die von dir genannten Punkte noch hier im PR ergänzen, da dieser sonst nicht nutzbar ist.
edit: der sinn des puppet-scripts besteht ja darin, dass keine manuellen eingriffe mehr auf ner maschine nötig sind nach nem run. von daher sollten diese dinge integriert werden, sodass dies der fall ist.
Thanks for your work. I talked with @ohrensessel and it would be really awesome if you could provide:
I think the firewall can be done within this PR https://github.com/ffnord/ffnord-puppet-gateway/pull/118
I already added the example in the README.md
what else would be needed?
no, it cannot. PR #118 just updates the firewall framework. each module has to add a rule for the ports it needs by defining ffnord::firewall::service with the appropriate parameters (see https://github.com/ffnord/ffnord-puppet-gateway/blob/master/manifests/fastd.pp#L55-L59)
Then everything should be ok already: https://github.com/ffnord/ffnord-puppet-gateway/pull/120/files#diff-e83e93e7402ec3932435863e37a7b834R59
Each fastd instance gets his own $mesh_interface
so there is one firewall rule for each.
the first instance (1280) is defined in init.pp and the old (1426) in the example in README.md
If you still want to run a gateway with only the 1426MTU then you would have to define this in your manifest. If you don't choose an MTU the default will be 1280 now.
As everything is clear now I am going to merge this. Thank you.
sorry, but I still have some open points.