search

ffnord / mesh-announce

Discussion at #mesh-announce:irc.hackint.org and (separately) at
https://matrix.to/#/!MjLIHcALOcENXZWQlH:irc.hackint.org/$1547640760901FmKaD:matrix.eclabs.de
13 stars 45 forks source link

Feature batctl version autodetect #51

Closed TobleMiner closed 3 years ago

TobleMiner commented 4 years ago

Should fix #50 . Please test

margau commented 4 years ago

Works with batctl debian-2019.4-1 [batman-adv: 2018.3] without warnings.

margau commented 4 years ago

Seems not to work (Output: Jan 9 17:28:03 gw03 sh[3660]: Warning - option -m was deprecated and will be removed in the future)

batctl -v batctl debian-2019.5-1 [batman-adv: 2019.4]

I'll try to investigate further in the next days.

AiyionPrime commented 3 years ago

~The fix is very simple, replace -m with meshif like their manpage suggests.~ edit: thx captain

PR looks good, will test later.

AiyionPrime commented 3 years ago

And next time. I'll read the PR fully before answering half baked nonsense. Sorry. PR looks good though, just merged it into something near master again, which is what I tested then on our supernode: https://github.com/freifunkh/mesh-announce/commit/cf67269f62007ad07ed0740eec2ae131d763eb5a

I'd personally not care for versions before batctl 2019.3 and still just merge #64.

But this gets rid of the warning as well for batctl 2021.0 Tested on Debian Buster.

AiyionPrime commented 3 years ago

@TobleMiner maybe you find time to rebase this to master yourself? If you'd have a look at my merge above, you could evaluate if you'd merged the same way and whether my tests need to be done again on your rebased PR.

herbetom commented 3 years ago

Made a PR for this PR: TobleMiner/mesh-announce/pull/1

I should probably just open a new PR :thinking:

Didn't test it with something other then the batctl on my system (a current version) if this fallback really works, no idea