search

ffnord / mesh-announce

Discussion at #mesh-announce:irc.hackint.org and (separately) at
https://matrix.to/#/!MjLIHcALOcENXZWQlH:irc.hackint.org/$1547640760901FmKaD:matrix.eclabs.de
13 stars 45 forks source link

Replace deprecated batctl parameter #64

Closed AiyionPrime closed 3 years ago

AiyionPrime commented 3 years ago

This commit will get rid of the warning messages @margau found in PR https://github.com/ffnord/mesh-announce/pull/51#issuecomment-572641823

The referenced mail contains the original commit, where -m got deprecated. This should be rather quick to fix.

closes #50

My related commit message:

batctls syntax is changing and deprecated the usage of -m and suggests 'meshif' as drop in replacement.

https://lists.open-mesh.org/mailman3/hyperkitty/list/b.a.t.m.a.n@lists.open-mesh.org/thread/AHRNDJTW3HNU5NQ5MVI6WZEZZ32PBHZT/

AiyionPrime commented 3 years ago

Gets rid of these messages: Feb 14 13:28:30 h2879555.stratoserver.net respondd.py[30134]: Warning - option -m was deprecated and will be removed in the future

Sucessfully tested with batctl 2021.0 and debian buster.

herbetom commented 3 years ago

While i personally i would be fine with just don't supporting those old batman versions, i would probably go with #80 (the rebased version of #51) if that's working. The call_batctl method from that is also needed for #79

So I would probably close this, but we can discuss that tomorrow.

AiyionPrime commented 3 years ago

We decided on merging #80 instead.