search

ffnord / mesh-announce

Discussion at #mesh-announce:irc.hackint.org and (separately) at
https://matrix.to/#/!MjLIHcALOcENXZWQlH:irc.hackint.org/$1547640760901FmKaD:matrix.eclabs.de
13 stars 45 forks source link

feature: option to override the hostname #65

Closed AiyionPrime closed 3 years ago

AiyionPrime commented 3 years ago

btw, is there an option to override the hostname?

I don't think so, but with the config file it should be easilier possible to add such an option, since their is to need to add another argc. :smile:

Originally posted by @herbetom in https://github.com/ffnord/mesh-announce/issues/60#issuecomment-669402551

This could improve usability on cheap VPS hosts, where hostnames get changed on a regular basis by the hoster.

herbetom commented 3 years ago

I did something which just needs another solution for the float conversion: https://github.com/ffnord/mesh-announce/pull/63/files

AiyionPrime commented 3 years ago

Looks very promising, another solution differently like what?

herbetom commented 3 years ago

IIRC float and the fallback to None are not really compatible or something along those lines.

AiyionPrime commented 3 years ago

Not tested this, but the only thing irritating about this is the rather unsafe conversion to float; but as it does this only with localconfig values, it should not be a huge problem, I think.

AiyionPrime commented 3 years ago

Just clarify; his code works fine and would resolve this issue.