Closed AiyionPrime closed 3 years ago
@herbetom, does this suit you as well?
Tested on one of our supernodes as well; works as intended, if no option, a valid or an invalid one is given.
Looks okay, i'm testing it later :+1:
Thanks
btw, what protocol are you using instead of fastd?
btw, what protocol are you using instead of fastd?
see here: https://github.com/ffnord/mesh-announce/issues/66#issuecomment-779409783
I only checked if #66 is solved with it. It seems that way. What i couldn't easily test is the actual output.
What i tested:
VPNProtocol: fastd
(as the Default Setting)VPNProtocol: None
(as the Default Setting)Well this is worse than before; the list produces TypeError: unhashable type: 'list'
And ready again.
It's getting quite a massacre by now, but @freifunkh runs mesh-announce upstream/master with #63, #64, #69, #70 as well as #71 merged concurrently without problems.
example: https://hannover.freifunk.net/karte/#/en/map/88e640ba7014
I think the 3 commits should be squashed. They currently contradict each other. That makes applying them a pain.
@herbetom yeah, good idea. Thoug I think I'll leave them unsquashed until one of Kiels members acked the proposed changes and make less commits of it right before the merge.
This gets rid of fastd for those who don't want it anymore, while letting it be as the default for any current users.