search

ffnord / meshviewer

This Fork is not maintained. Please use https://github.com/ffrgb/meshviewer
GNU Affero General Public License v3.0
33 stars 40 forks source link

wanted : clients/gw in Statistics? #27

Open viisauksena opened 8 years ago

viisauksena commented 8 years ago

interested in a pull request similar to this https://github.com/plumpudding/hopglass/pull/9

tcatm commented 8 years ago

This is a little hard to read. It seems to add multiple features. Can you split it into seperate ones and describe them?

I don't like the introduction of count2. Rather,count should be generalized (that is the +1 term should be made configurable) to avoid duplicating code.

viisauksena commented 8 years ago

this are 2 features :

  1. make h2 elements incl their table hidden-able (by onclick)
  2. add client per gateway table based on statistics.clients.total given by each node itself, therefore you need this "other" count.

js is normaly beyond my scope - ive done this with a friend, and if you like i write a patch like this based on your actual code - but o wont do any extra work beside that (like ive done for hopglass - based on freiburg freifunk meshviewer https://openfreiburg.de/freifunk/meshviewer , our "adjustements")