search

ffont / freesound-explorer

Visual interface for exploring Freesound content and creating music in a 2-dimensional space
http://labs.freesound.org/fse/
MIT License
19 stars 3 forks source link

Adds stop all sounds playing #45

Closed noVaSon closed 6 years ago

noVaSon commented 6 years ago

I encountered this annoying issue #42 when using playOnHover. Longer Sounds would only be stoppable by clicking one playing sound after the other.

Now it is synchonized with deselectAllSounds when clicking the empty map.

Unfortunately, when exthausively using the playOnHover feature some state changes seem to be so slow, that not all sounds will reliably stop. But the majority of them will, so this is a small improvement.

ffont commented 6 years ago

I don't seem to be able to get this to work. Should all sounds stop playing when I click in an empty point in the map?

noVaSon commented 6 years ago

This is true! I must have accidentally excluded the MapContainer.jsx from the commit! Should work now.

ffont commented 6 years ago

Yeah now it works, although as you mention in the comment it is still a bit buggy. I'll merge that but I won't close issue https://github.com/ffont/freesound-explorer/issues/42. Will add a comment about the buggy behavior that should be fixed at some point.

ffont commented 6 years ago

After merging #39 this branch has now conflicts with master. @noVaSon you should merge master to this branch and resolve the conflicts, then I'll merge.