search

ffont / freesound-explorer

Visual interface for exploring Freesound content and creating music in a 2-dimensional space
http://labs.freesound.org/fse/
MIT License
19 stars 3 forks source link

Brushing some dust away #75

Open noVaSon opened 3 years ago

noVaSon commented 3 years ago

Dearest creators of this awesome project!

Hope you are doing very well!

I am planning to do a little talk for a local dev community on react in Juli and wanted to have a quick walkthrough the FSE. Now I feel like I should have some fresh lines here in order to be up to the state of the art.

So, recently I updated the most dependencies of the FSE.

Maybe there are a few points, where your experience can guide me out of the woods:

1.) I struggle hard with generating source maps for debugging in VSC. There is a failing test of the Midi reducer, where the Array.split method does not work as expected, and stagnate here, because I need a better way to analyse the code.

2.) The flask login icon doesnt show up, I did not dive into this one yet, but since there are no tests and no exceptions, this could be a little harder. Since Python 2 has finally come to rest, an Python 3 upgrade would probably be a good idea - depending on the versions installed on the host.

If you find the time to give me a helping hand, you may pull the current commit at the update-deps branch from my fse fork:

https://github.com/noVaSon/freesound-explorer/tree/update-deps

Best, Eric

ffont commented 3 years ago

Hi Eric! How are you doing? As you have seen there has been no activity here since the last time you contributed to the repo. Also I have not been involved in any JS+React intensive development so I'm really out of date in all that... @giuband is always pretty busy so I don't think he will chime in. Regarding your questions:

1.) I struggle hard with generating source maps for debugging in VSC. There is a failing test of the Midi reducer, where the Array.split method does not work as expected, and stagnate here, because I need a better way to analyse the code.

Ups, I have really no idea... :(

2.) The flask login icon doesnt show up, I did not dive into this one yet, but since there are no tests and no exceptions, this could be a little harder. Since Python 2 has finally come to rest, an Python 3 upgrade would probably be a good idea - depending on the versions installed on the host.

You mean the icon in the UI? Hmm IIRC the login icon will only appear when FSE is launched from the flask backed (or if it detects it?). A python 3 version would be much needed yes, although we could dockerize the backend as well to make sure it will continue working without issues. Are you having problems running it? I can help with the dockerization as this is something I wanted to do anyway.

Also, considering that I don't have much time to dedicate to the project and that I think that you're the one now in the better position to continue extending it (or doing small maintenance), I would not mind if you work directly in this repository and make/merge PRs as you wish. We'll have to coordinate for deploying updated versions, but that is fine. Do you have enough permissions to edit this repo?

noVaSon commented 3 years ago

Hi Frederic!

Thank you, we are fine here! Hope you are feeling good as well.

Don't mind the first issue, I will fight and win :>

But the dockerization might be a good idea. I started to play around with it some time ago - we could do it.

I managed to start the flask backend with changing one line of code, but it doesn't talk to the frontend yet. I'll push into my fork so that you can pull it.

Seems like I can edit files, so I should have permissions for the original fse.