search

ffraenz / private-composer-installer

Composer install helper outsourcing sensitive keys from the package URL into environment variables
MIT License
227 stars 16 forks source link

Incompatile with prestissimo plugin #21

Closed szepeviktor closed 4 years ago

szepeviktor commented 4 years ago

I think it tries to download from the stored URL.

    62/67:      https://codeload.github.com/symfony/polyfill-ctype/legacy.zip/550ebaac289296ce228a706d0867afc34687e3f4
    0: :        https://connect.advancedcustomfields.com/index.php
    63/67:      https://codeload.github.com/squizlabs/PHP_CodeSniffer/legacy.zip/65b12cdeaaa6cd276d4c3033a95b9b88b12701e7

https://github.com/hirak/prestissimo

May be related to https://github.com/hirak/prestissimo/issues/219

Please advise.

ffraenz commented 4 years ago

Please provide your composer.json or a similar test case to reproduce the bug. What do you mean by 'the stored URL'?

szepeviktor commented 4 years ago
  1. composer global require hirak/prestissimo
  2. Set up private-composer-installer with e.g. ACF Pro
  3. run composer update
  4. See the output above: prestissimo fails to preload ACF Pro, it keeps trying for a while...
  5. Then in installation phase Composer finally downloads ACF Pro from the correct URL (not from local cache as every other package)
szepeviktor commented 4 years ago

What do you mean by 'the stored URL'?

the one without secrets, with placeholders

szepeviktor commented 4 years ago

so actually prestissimo abuses the ACF download server...

mcaskill commented 4 years ago

@szepeviktor Are you using the correct URI and placeholders for dist.url as shown on the README?

https://connect.advancedcustomfields.com/index.php?a=download&p=pro&k={%ACF_PRO_KEY}&t={%VERSION}

As for hirak/prestissimo#219, that is related affecting pivvenit/acf-pro-installer and is related to this: PhilippBaschke/acf-pro-installer#20.

szepeviktor commented 4 years ago

I think yes. It was long time ago.

"https://connect.advancedcustomfields.com/index.php?p=pro&a=download&t={%VERSION}&k={%ACF_PRO_KEY}"
ffraenz commented 4 years ago

@szepeviktor Is this still relevant or may I close this issue?

szepeviktor commented 4 years ago

Let's close it!