search

ffulm / firmware

The Firmware for the Freifunk Ulm Community
http://www.freifunk-ulm.de/
Other
11 stars 14 forks source link

Google Translate API integrated #18

Closed chankruze closed 6 years ago

chankruze commented 6 years ago

It is simplified now.You should review the code & i think this is mergable.

chankruze commented 6 years ago

Hi @mwarning i am just informing you that I used js to add Google Translate API in both pull request #17 & #18 but i closed #17 because i found it will be more informative if i include the function in shared.js.

There is no conflict with this code therefore i am asking to review and merge it.It will be very helpful for non german users to understant web interface.

mwarning commented 6 years ago

hi @geekofia, thanks for your effort. I need to think about a solution here. The problem is, that the router is expected to work without Internet access. This makes it desirable to have translations working without Internet access.

chankruze commented 6 years ago

First of all thanks for reviewing.You have a solid point.I will think a solution for it.

chankruze commented 6 years ago

I think now only solution is to save translations to a variable in separate js file. We can call a function with event listener to change language on click.

mwarning commented 6 years ago

I agree.

chankruze commented 6 years ago

Is some one working on multi language support ? Or i should start working ?

mwarning commented 6 years ago

hi @geekofia, I forgot about this ticket. Sorry about that. How about something like this: https://github.com/freifunk-bielefeld/firmware/commit/d013faa6a6df31c12e54c9f4248a7c352e5b1998

It's really simple but might work. Translations are not integrated yet. The language of the default text could be english.

chankruze commented 6 years ago

Yes that should work.Need the whole lines to be translated.I have translated them.If need you can comment.

mwarning commented 6 years ago

I think it is better to translate the whole lines. Can you do a pull request with the translations? Then I can merge them. :-)

chankruze commented 6 years ago

please see closed pull request #16.And let me know is that what you need or anything else ?

mwarning commented 6 years ago

The data is all there. But it need to be put together :-) The branch from #16 is not available anymore. So this will be a lot of manual work.

chankruze commented 6 years ago

I am translating (like #16), clean forked and if i translate the german lines to english in html and js (help texts) ..then the german will be replaced with english ... is it okay ?

mwarning commented 6 years ago

That would be great! Anyway, time for me to go to bed now.