search

ffverse / ffscrapr

R API Client for Fantasy Football League Platforms
https://ffscrapr.ffverse.com
Other
83 stars 21 forks source link

Overall Pick variable in ff_draft() #260

Closed TheMathNinja closed 3 years ago

TheMathNinja commented 3 years ago

Is it possible to read in the overall pick number as its own variable in the ff_draft() function? (I know MFL's draft report calls this "ovr"). Currently ff_draft() just returns round number and pick within the round.

Especially in leagues that use compensatory picks or toilet bowl sorts of bonus picks at ends of rounds, getting this number directly from the source rather than creating it via scripts could be really helpful, thanks.

tanho63 commented 3 years ago

This is just dplyr::row_number I think

TheMathNinja commented 3 years ago

If you run Deluxe Leagues in MFL and it returns multiple drafts, then that doesn't quite work super simply (needs a group_by). Anyway, I just thought MFL probably supplied it since it's in the draft readout. But if it bogs down the package, no worries.

tanho63 commented 3 years ago

aye, probably, got an example league/

Tan Ho

On Fri, Apr 9, 2021 at 4:37 PM Mike Filicicchia @.***> wrote:

If you run Deluxe Leagues in MFL and it returns multiple drafts, then that doesn't quite work super simply (needs a group_by). Anyway, I just thought MFL probably supplied it since it's in the draft readout. But if it bogs down the package, no worries.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dynastyprocess/ffscrapr/issues/260#issuecomment-816958493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJCRZ35UODOFYPWKVOJRAU3TH5QRLANCNFSM42VNPFBA .

TheMathNinja commented 3 years ago

I do have an example, but I don't have a problem in my code. It works just fine. But if you want one to play around with, the league is league_id 60206 on MFL. Any year 2016-2020 will work.