ff_scoringhistory has no sleeper ID for rookie

[christianlohr9]

Since that was a bug in nflfastR I assume every function with sleeper IDs will experience the same issue. Unfortunately I was joining in many scripts by using sleeper_id instead of gsis :D

As always many thx in advance!!!

Reprex

library(tidyverse)
ffscrapr::ff_scoringhistory(ffscrapr::sleeper_connect(season = 2022, league_id = "865508461486682112"),
                            season = 2022) %>% filter(player_name %in% c("Drake London","Chris Olave"))
#> # A tibble: 4 × 30
#>   season  week gsis_id    sportrada…¹ sleep…² playe…³ pos   team  points attem…⁴
#>    <int> <int> <chr>      <chr>       <chr>   <chr>   <chr> <chr>  <dbl>   <dbl>
#> 1   2022     1 00-0037238 <NA>        <NA>    Drake … WR    ATL     13.8       0
#> 2   2022     2 00-0037238 <NA>        <NA>    Drake … WR    ATL     21.7       0
#> 3   2022     1 00-0037239 <NA>        <NA>    Chris … WR    NO       9.7       0
#> 4   2022     2 00-0037239 <NA>        <NA>    Chris … WR    NO      12         0
#> # … with 20 more variables: carries <dbl>, completions <dbl>,
#> #   interceptions <dbl>, passing_2pt_conversions <dbl>,
#> #   passing_first_downs <dbl>, passing_tds <dbl>, passing_yards <dbl>,
#> #   receiving_2pt_conversions <dbl>, receiving_first_downs <dbl>,
#> #   receiving_fumbles_lost <dbl>, receiving_tds <dbl>, receiving_yards <dbl>,
#> #   receptions <dbl>, rushing_2pt_conversions <dbl>, rushing_first_downs <dbl>,
#> #   rushing_fumbles_lost <dbl>, rushing_tds <dbl>, rushing_yards <dbl>, …
Ā
#> Error in eval(expr, envir, enclos): object 'Ā' not found

^{Created on 2022-09-21 with reprex v2.0.2}

[tanho63]

This is really dp_playerids() doesn’t have rookie gsis_ids, right?

[christianlohr9]

Yh it is. So the main issue is within dp_playerids() (or within nflfastR lol), yes