ffverse / ffscrapr

R API Client for Fantasy Football League Platforms
https://ffscrapr.ffverse.com
Other
76 stars 21 forks source link

Problem with team designation in espn_players() #392

Closed TheMathNinja closed 1 year ago

TheMathNinja commented 1 year ago

Describe the bug espn_players(season = 2020) shows J.J. Watt on ARI, but he was not on ARI for any part of the 2020 season. Is this an issue of when that data is updated on ESPN's platform, or is something wrong with espn_players()? This is a real pain when trying to join by team.

Reprex espn_players(season = 2020)

N/A

Expected behavior Watt should be on HOU for 2020.

Session information Please copy the output of ffscrapr::ffverse_sitrep() into the box below.

── System Info ──────────────────────────────────────────────────────────────────
• R version 4.2.2 (2022-10-31 ucrt)   • Running under: Windows 10 x64 (build 22621)
── ffverse Packages ─────────────────────────────────────────────────────────────
• ffscrapr (1.4.7.13)
── ffverse Options ──────────────────────────────────────────────────────────────
No options set for ffscrapr
── ffverse Dependencies ─────────────────────────────────────────────────────────
• askpass    (1.1)     • glue      (1.6.2)  • rappdirs   (0.3.3)  
• assertthat (0.2.1)   • httr      (1.4.4)  • ratelimitr (0.4.1)  
• backports  (1.4.1)   • jsonlite  (1.8.3)  • rlang      (1.0.6)  
• cachem     (1.0.6)   • lifecycle (1.0.3)  • stringi    (1.7.8)  
• checkmate  (2.1.0)   • magrittr  (2.0.3)  • stringr    (1.5.0)  
• cli        (3.4.1)   • memoise   (2.0.1)  • sys        (3.4.1)  
• cpp11      (0.4.3)   • mime      (0.12)   • tibble     (3.1.8)  
• curl       (4.3.3)   • nflreadr  (1.3.2)  • tidyr      (1.2.1)  
• data.table (1.14.6)  • openssl   (2.0.5)  • tidyselect (1.2.0)  
• dplyr      (1.0.10)  • pillar    (1.8.1)  • utf8       (1.2.2)  
• fansi      (1.0.3)   • pkgconfig (2.0.3)  • vctrs      (0.5.0)  
• fastmap    (1.1.0)   • purrr     (0.3.5)  • withr      (2.5.0)  
• generics   (0.1.3)   • R6        (2.5.1)    
────────────────────────────────────────────────────────────

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

tanho63 commented 1 year ago

This looks like an issue with how ESPN’s API responds to the query. Not sure there’s anything for us to do here.