ffverse / ffscrapr

R API Client for Fantasy Football League Platforms
https://ffscrapr.ffverse.com
Other
76 stars 21 forks source link

ff_league() not functioning with MFL #402

Closed wadefuller closed 11 months ago

wadefuller commented 1 year ago

Describe the bug ff_league() is throwing an error. Unable to access the league.

Reprex

 # Please include the code used for the connection object from `ff_connect()`
ssb <- ff_connect(platform = "mfl", league_id = "65804", season = 2023)
ff_league(ssb)

Expected behavior Should be able to see the league details. Looks like the built in function is looking for points which is not in the data table (maybe it changed during the off-season).

Session information Please copy the output of ffscrapr::ffverse_sitrep() into the box below.

── System Info ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.3.0 (2023-04-21)   • Running under: macOS Ventura 13.4.1
── ffverse Packages ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• ffscrapr (1.4.8.03)
── ffverse Options ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
No options set for ffscrapr
── ffverse Dependencies ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass    (1.1)     • glue      (1.6.2)  • rappdirs   (0.3.3)   
• assertthat (0.2.1)   • httr      (1.4.6)  • ratelimitr (0.4.1)   
• backports  (1.4.1)   • jsonlite  (1.8.4)  • rlang      (1.1.1)   
• cachem     (1.0.8)   • lifecycle (1.0.3)  • stringi    (1.7.12)  
• checkmate  (2.2.0)   • magrittr  (2.0.3)  • stringr    (1.5.0)   
• cli        (3.6.1)   • memoise   (2.0.1)  • sys        (3.4.1)   
• cpp11      (0.4.3)   • mime      (0.12)   • tibble     (3.2.1)   
• curl       (5.0.0)   • nflreadr  (1.3.2)  • tidyr      (1.3.0)   
• data.table (1.14.8)  • openssl   (2.0.6)  • tidyselect (1.2.0)   
• dplyr      (1.1.2)   • pillar    (1.9.0)  • utf8       (1.2.3)   
• fansi      (1.0.4)   • pkgconfig (2.0.3)  • vctrs      (0.6.3)   
• fastmap    (1.1.1)   • purrr     (1.0.1)  • withr      (2.5.0)   
• generics   (0.1.3)   • R6        (2.5.1)    

Screenshots image

Additional context Add any other context about the problem here.

tanho63 commented 1 year ago

Looks like an issue with ff_scoring() in specific.

tanho63 commented 11 months ago

Should be resolved in latest development version, use remotes::install_github("ffverse/ffscrapr") to install