Open TheMathNinja opened 10 months ago
Looks related to #414. Definitely an API change I think. I’m away til Tuesday next week, I’ll try to get to it around then.
I’ll probably track it in 414 since that’s more specific to ff_scoring
Looks like different issue, so reopening this again. Is thresholdPoints a new addition to the scoring for this year?
Thanks so much for working on this @tanho63!
Any updates on this one? Is it pretty complex?
Yeah, somewhat complex. Limiting factor is lack developer time though
Hey all, I’m picking this up again with @TheMathNinja. Looks like one workaround is just to use the prod branch (1.4.8) instead of the dev branch head (1.4.8.17); on prod, ff_playerscores() (the original use case) appears to run just fine, dev reproduces the original error. Any idea which commit on the dev branch could cause this divergence? I’m a far cry from an R developer, but happy to help hack in a fix where I can.
Describe the bug Running ff_playerscores() now returns an error for my MFL league.
Reprex
Expected behavior I expect it to return a df, but I'm getting an error: Error in
dplyr::mutate()
: ℹ In argument:rule = purrr::map(.data$rule, parse_rule)
. Caused by error inpurrr::map()
: ℹ In index: 10. Caused by error inmutate()
: ℹ In argument:thresholdPoints = (structure(function (..., .x = ..1, .y = ..2, . = ..1) ...
. Caused by error: !thresholdPoints
must be size 12 or 1, not 5.Session information Please copy the output of
ffscrapr::ffverse_sitrep()
into the box below.Screenshots If applicable, add screenshots to help explain your problem.
Additional context Add any other context about the problem here.