search

ffverse / ffscrapr

R API Client for Fantasy Football League Platforms
https://ffscrapr.ffverse.com
Other
76 stars 21 forks source link

Fix max week in `ff_starters()` (ESPN) #423

Closed tonyelhabr closed 7 months ago

tonyelhabr commented 7 months ago

Given the logic for ff_starters() for Sleeper and the fact that I can't retrieve week 18 starter scores for my league last year (yes, we play through week 18 for some reason), I think < max week should be <= max week.

tonyelhabr commented 7 months ago

silly me thinking that would work without running tests locally

tonyelhabr commented 7 months ago

silly me thinking that would work without running tests locally

wait, i believe we just need to update the cache GitHub release (rebuild and add week 18 data), like was done last time. no rush on this.

tanho63 commented 7 months ago

/rebuild-tests