search

ffvvc / FFmpeg

VVC Decoder for ffmpeg
Other
48 stars 12 forks source link

remove min_scan_x, min_scan_y and find a better way to get max_scan_x and max_scan_y. #179

Open nuomi2021 opened 6 months ago

nuomi2021 commented 6 months ago

see https://patchwork.ffmpeg.org/project/ffmpeg/patch/TYSPR06MB64337C13ECE97978A56C1152AA62A@TYSPR06MB6433.apcprd06.prod.outlook.com/#81903

hamzah-mujawar commented 4 months ago

Progress Update:

I have located the file that I need to work on vvc_cabac.c, and found where max_scan and min_scan are defined: image

I took a look at the definition of FFMAX: image

hamzah-mujawar commented 4 months ago

Progress update:

I have added this line of code to help me understand what is going on: image

This is the resulting output: image

From my understanding, this returns the max of xc and yc respectively.

I have a question, do we need to find the highest xc and yc value overall, since from what I've seen the higher the xc and yc value that's what max_scan tends to stay on.

Thanking you for your time, Hamzah Mujawar