search

ffvvc / FFmpeg

VVC Decoder for ffmpeg
Other
48 stars 12 forks source link

Fix init task #216

Closed nuomi2021 closed 1 month ago

nuomi2021 commented 2 months ago

@frankplow , this will fix all three files you send me. please help review.

frankplow commented 2 months ago

@nuomi2021 LGTM! Can confirm it fixes the hang with those bitstreams, plus also another ~dozen bitstreams I had which were causing hangs. Don't have any bitstreams which cause hangs now.

frankplow commented 2 months ago

@nuomi2021 Actually it looks like while this patch fixes most hangs, it causes a regression which makes some other bitstreams hang. For example id:000132 fails on the assertion https://github.com/ffvvc/FFmpeg/blob/e81b6d78fc2ddf8edd53a6a052713354ef8d27c2/libavcodec/vvc/vvc_thread.c#L182 before the patch, but hangs after the patch.

nuomi2021 commented 2 months ago

hmm, could you help https://github.com/ffvvc/FFmpeg/issues/218 and add all fixed fuzz clips to failed/fuzz/ ? thank you

nuomi2021 commented 2 months ago

@frankplow how about the latest one :)

frankplow commented 2 months ago

@nuomi2021 Yes, seems to have done the trick!

nuomi2021 commented 2 months ago

@frankplow clip name is not valid on Windows :)

frankplow commented 2 months ago

@frankplow clip name is not valid on Windows :)

Fixed in https://github.com/ffvvc/tests/pull/32