search

ffvvc / FFmpeg

VVC Decoder for ffmpeg
Other
50 stars 12 forks source link

valgrind issue for SAO filter. #26

Open nuomi2021 opened 1 year ago

nuomi2021 commented 1 year ago

run "valgrind ./ffmpeg_g -i SLICES_A_HUAWEI_3.bit -f rawvideo /dev/null -y"

you will get

==5154== Use of uninitialised value of size 8 ==5154== at 0x46E433: sao_edge_filter_10 (vvcdsp_template.c:200) ==5154== by 0x50ACE9: ff_vvc_sao_filter (vvc_filter.c:309) ==5154== by 0x52C1DB: run_sao (vvc_thread.c:447) ==5154== by 0x52B462: ff_vvc_task_run (vvc_thread.c:567) ==5154== by 0x500AE9: executor_worker_task (executor.c:79) ==5154== by 0x49C8608: start_thread (pthread_create.c:477) ==5154== by 0x4B02132: clone (clone.S:95)

It's realted to sao temporary buffer lc->sao_buffer, once you memset the buffer here , valgrind will not report any issue.

light2802 commented 1 year ago

Hi @nuomi2021. My name is Aarya Chaumal and I would like to take this issue up as my qualification task for this year's GSoC any advice on how should I set up my development environment for this task? I'm on a Linux machine.

nuomi2021 commented 1 year ago

great! you can check https://github.com/ffvvc/FFmpeg/blob/main/.github/workflows/makefile.yml for configuration and bitstream download. thank you

light2802 commented 1 year ago

Okay so I was able to build. (Encountered some issue with yasm, so switched to nasm)

nuomi2021 commented 1 year ago

@light2802 is everything smooth? thank you

light2802 commented 1 year ago

I sent a patch to the ffmpeg-devel mailing list but it is not showing up on the patchwork.ffmpeg.org/ page

nuomi2021 commented 1 year ago

the code is not merged by ffmpeg yet. could you help send pr to https://github.com/ffvvc/FFmpeg instead?

thank you

light2802 commented 1 year ago

Sure created a PR at https://github.com/ffvvc/FFmpeg/pull/49

nuomi2021 commented 1 year ago

remove low priority since #64