ffvvc / FFmpeg

VVC Decoder for ffmpeg
Other
50 stars 12 forks source link

Add AVX2 assembly code for SAO filter #45

Closed nuomi2021 closed 1 year ago

nuomi2021 commented 1 year ago

VVC SAO near same as HEVC. We can fully reuse HEVC SAO code for VVC. Please add AVX2 for VVCSAODSPContext

nuomi2021 commented 1 year ago

On Mon, Mar 13, 2023 at 1:06 AM PirateOfAndaman @.***> wrote:

I would like to take up this issue.

— Reply to this email directly, view it on GitHub https://github.com/ffvvc/FFmpeg/issues/45#issuecomment-1465249664, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR75SZYHNJ2I3H34MROBDV3W3X7CTANCNFSM6AAAAAAVVGDSTY . You are receiving this because you authored the thread.

sure, please comment on the github page, I will assign to you. Thank you.

Message ID: @.***>

zackerthescar commented 1 year ago

Hi, I've sent you an email r.e my work on this issue. If possible, please assign me to this issue.

While I don't think I'm ready for a pull request yet, you can check out fork here: https://github.com/zackerthescar/FFmpeg

PirateOfAndaman commented 1 year ago

I actually asked for this issue but then realized the asm coding skills required were much greater than I knew therefore I deleted the comment on github, but by then the automated email was already sent. Can you point me to any resource for learning more about encoding or any books with might help with the coding involved in these?

Found it: http://ffmpeg.org/documentation.html

zackerthescar commented 1 year ago

Please see pull request #53

nuomi2021 commented 1 year ago

I actually asked for this issue but then realized the asm coding skills required were much greater than I knew therefore I deleted the comment on github, but by then the automated email was already sent. Can you point me to any resource for learning more about encoding or any books with might help with the coding involved in these?

Found it: http://ffmpeg.org/documentation.html

you can check https://blogs.gnome.org/rbultje/2017/07/14/writing-x86-simd-using-x86inc-asm/ and https://www.nasm.us/docs.php

nuomi2021 commented 1 year ago

fixed by https://github.com/ffvvc/FFmpeg/pull/85

nuomi2021 commented 1 year ago

thank you @zackerthescar