ffxiv-teamcraft / simulator

Crafting simulator for FINAL FANTASY XIV
MIT License
24 stars 18 forks source link

bug: inaccurate rounddown calculation in crafting simulator #16

Closed Gojob2987 closed 4 years ago

Gojob2987 commented 4 years ago

Describe the bug In a crafting process, when the actual result of "Quality per 100% efficiency" is 763.99 (float), the crafting simulator will take the value as 764 (int), while in game the value is taken as 763 (int).

To Reproduce Steps to reproduce the behavior:

  1. Go to https://ffxivteamcraft.com/simulator
  2. Search and select recipe "Tincture of Intelligence"
  3. Input crafter attribute: 2362 craftsmanship, 2029 control, 600 cp, 80 level
  4. Scroll down and click "Apply stats"
  5. Scroll down to crafting action section and click the icon with tooltip name "Reflect"
  6. Click the icon with tooltip name "Preparatory Touch"
  7. Scroll up to check that Inner Quiet has 5 stacks, Current Control is 3652
  8. Check the value of "Quality per 100% efficiency", it's 764 (instead of 763)

Expected behavior When a lvl80 Alchemist with 2029 control crafts the recipe "Tincture of Intelligence", at 5 Inner Quiet stacks (3652 Control) the Quality per 100% efficiency should be round down to 763. See screenshot for in game behavior.

Screenshots crafterAttribute

defaultEfficiencyIncrease

teamcraftResult

Desktop (please complete the following information):

Additional context (First time writing issue...hope my description isn't too messy

Igie commented 4 years ago

I think this has been resolved as the value shown is correct but has not yet been marked as closed. Just a reminder to someone who can close this