search

ffxiv-teamcraft / simulator

Crafting simulator for FINAL FANTASY XIV
MIT License
24 stars 18 forks source link

bug: Final Appraisal functioning incorrect #17

Closed italicninja closed 4 years ago

italicninja commented 4 years ago

Describe the bug When using Final Appraisal in the simulator the functionality is different than when in game

Using the Leather Macro here: https://ffxivteamcraft.com/simulator/27743/33330/ZByhw59RaUbiKDrLhqQp

The simulator show the macro will succeed whereas in game the macro fails after the FA step into Delicate Synthesis.

This is likely due to how FA interacts with Manipulation

Supamiu commented 4 years ago

Hey, thank you for the report.

Can you add your stats please so I can reproduce properly?

Le mar. 26 nov. 2019 à 08:43, Ian notifications@github.com a écrit :

Describe the bug When using Final Appraisal in the simulator the functionality is different than when in game

Using the Leather Macro here: https://ffxivteamcraft.com/simulator/27743/33330/ZByhw59RaUbiKDrLhqQp

The simulator show the macro will succeed whereas in game the macro fails after the FA step into Delicate Synthesis.

This is likely due to how FA interacts with Manipulation

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ffxiv-teamcraft/simulator/issues/17?email_source=notifications&email_token=ACX4JY4BYVAELZQJY7724YDQVTHSHA5CNFSM4JRT2IB2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4H4A7ISQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACX4JY6GT76R4DPATYZ6LLDQVTHSHANCNFSM4JRT2IBQ .

italicninja commented 4 years ago

Base stats are: Craft: 2439 Control: 2475 CP: 556

ayyaruq commented 4 years ago

@Metra1337 as far as I can tell Final Appraisal functions properly with Manipulation now. Your rotation breaks for other reasons, notably using a 10 dura action under manip with 10 dura left (so manip can't refund dura as it already hits 0), but FA itself isn't ticking manip or refunding dura which should match the game. Are you able to verify it's working as you expect now?

italicninja commented 4 years ago

Yeah It looks good!