Closed ayyaruq closed 4 years ago
Merging #23 into master will increase coverage by
2.64%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 43.11% 45.75% +2.64%
==========================================
Files 50 50
Lines 1336 1355 +19
Branches 129 138 +9
==========================================
+ Hits 576 620 +44
+ Misses 757 730 -27
- Partials 3 5 +2
Impacted Files | Coverage Δ | |
---|---|---|
...c/model/actions/progression/intensive-synthesis.ts | 0.00% <0.00%> (-79.17%) |
:arrow_down: |
src/simulation/simulation.ts | 50.64% <0.00%> (+1.29%) |
:arrow_up: |
src/model/actions/crafting-action.ts | 71.23% <0.00%> (+3.96%) |
:arrow_up: |
src/model/actions/progression/groundwork.ts | 65.00% <0.00%> (+65.00%) |
:arrow_up: |
src/model/actions/buff/waste-not.ts | 69.56% <0.00%> (+69.56%) |
:arrow_up: |
src/model/actions/buff/veneration.ts | 71.42% <0.00%> (+71.42%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 91244bb...208b0df. Read the comment docs.
The sim currently allows crafts even when your stats are too low. This change adds a failure clause for below minimum stats, which needs handling in Teamcraft, as well as checking if either of the stats have a set min and handling if you can craft or not. In terms of the TC simulator page, if food puts you over the min, it'll still work. This does not apply to custom sims, and
Community rotations will need to be adjusted independent for your stats if users want to filter on that though. The way fail causes are handled should prob be re-addressed in the future, just getting a string out of it is kinda gross.