search

ffxiv-teamcraft / simulator

Crafting simulator for FINAL FANTASY XIV
MIT License
24 stars 18 forks source link

Control to the Floor, I was sure #27

Closed ayyaruq closed 4 years ago

ayyaruq commented 4 years ago

Control bonus is an integer. Now we can ensure it's actually an integer. Error reported by perchbird.

codecov[bot] commented 4 years ago

Codecov Report

Merging #27 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   47.89%   47.89%           
=======================================
  Files          50       50           
  Lines        1376     1376           
  Branches      141      133    -8     
=======================================
  Hits          659      659           
  Misses        714      714           
  Partials        3        3
Impacted Files Coverage Δ
src/model/crafter-stats.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 59ab61f...8d1be60. Read the comment docs.

ayyaruq commented 4 years ago

Force pushed because Husky is a massive piece of shit. Nothing should ever be editing a commit between when it's committed and when it's pushed. Just fail the push in the pre-hook or something, I don't care.

Supamiu commented 4 years ago

Husky isn't editing your commit, it just ensures you follow the commit conventions, and if you don't, it'll block the commit, as it will make it not be included in https://github.com/ffxiv-teamcraft/simulator/blob/master/CHANGELOG.md.

Anyways, I'll squash.