search

ffxiv-teamcraft / simulator

Crafting simulator for FINAL FANTASY XIV
MIT License
24 stars 18 forks source link

Bug: Simulator - "Minimum stats" window does not properly reflect required CP/Control #5

Closed Patriclis closed 5 years ago

Patriclis commented 5 years ago

Describe the bug In all circumstances, the "Minimum Stats" window in the sim does not reflect the amount of CP consumed in the synth, instead it just shows the user's CP total.

Secondly, the Minimum Stats window shows the user's total control in a rotation that doesn't attempt to increase quality. It should instead show "0".

To Reproduce Steps to reproduce the behavior:

  1. Create new rotation for iron ingot.
  2. Set Crafts/Control to 9999, set CP to 100.
  3. Complete the rotation using a single "Standard Synthesis" consuming only 15 CP.
  4. {Bug} Click the "Minimum stats" Icon and see that the craft requires "101" CP.
  5. {Bug} Also note that the Control required is set to 10000 when it should be "0" as we didn't use any control enhancing actions.

Expected behavior Minimum CP should show the minimum amount of CP required to do the craft, taking into account Specialist CP buffs, comfort zone, and other CP restoring actions.

Minimum Control should report as "0" when no quality is 0.

Screenshots image

Desktop (please complete the following information):

Additional context Originally reported by Tarulia in discord.

Patriclis commented 5 years ago

This also effects the "Share with the community" initial Minimum CP + Control values.

image

Supamiu commented 5 years ago

I moved this to simulator as this feature is implemented inside the simulator directly :)

Supamiu commented 5 years ago

Fixed by https://github.com/ffxiv-teamcraft/simulator/commit/4451f351b530003fc2637a314995af7ba713fc70