ffxiv-teamcraft / simulator

Crafting simulator for FINAL FANTASY XIV
MIT License
24 stars 18 forks source link

Fix precision issue with buffMod calculation of Quality actions #60

Closed Kyuusokuna closed 2 years ago

Kyuusokuna commented 2 years ago

Issue:

Precision issue with Quality actions buffMod The calculation of the added quality for quality actions is not correctly constrained to be 32bit which in some cases it resulted in being off by 1.

Steps to Reproduce:

Setup: Craftsmanship: 813 Control: 683 CP: 283 Level: 68 Recipe: Rarefied Durium Rod

Rotation: ["innovation", "prudentTouch", "prudentTouch", "prudentTouch"]

Rotation Ingame Quality: 667 Rotation Teamcraft Quality: 666

Expected Behaviour:

The Quality in game and in Teamcraft should be the same. Teamcraft Version - Browser / Desktop Client 9.6.8 in Chrome and Standalone client

Screenshots: 1: Teamcraft result 2: ingame step 1 3: ingame step 2 4: ingame step 3 5: ingame step 4 / result

image image image image image