ffxivcode / AutoDuty

Dalamud Plugin for FFXIV - AutoDuty
71 stars 49 forks source link

[Bug] AutoDuty left Lunar Subterrane prematurely #485

Open AetherCollective opened 3 weeks ago

AetherCollective commented 3 weeks ago

What happened?

I was using AutoDuty to clear Lunar Subterrane with Duty Support when right before reaching the final boss, AutoDuty decided to leave prematurely, without defeating the final boss

Version Number

0.0.0.169

Steps to reproduce the error

afaik just enter Lunar Subterrane with Duty Support

Relevant log output

18:20:26.909 | DBG | [AutoDuty] Stage=Moving
18:20:34.130 | DBG | [AutoDuty] SchedulerHelper - RecentlyWatchedCutsceneTimer Added to Scheduler
18:20:39.148 | DBG | [AutoDuty] SchedulerHelper - Executing action RecentlyWatchedCutsceneTimer
18:20:39.148 | DBG | [AutoDuty] SchedulerHelper - RecentlyWatchedCutsceneTimer Removed from Scheduler
18:20:39.321 | DBG | [AutoDuty] SchedulerHelper - RecentlyWatchedCutsceneTimer Added to Scheduler
18:20:39.329 | DBG | [AutoDuty] Stage=Reading Path
18:20:39.382 | DBG | [AutoDuty] Starting to execute task: ExitDuty-Invoke
18:20:39.413 | INF | [AutoDuty] ExitDuty Started
18:20:39.420 | DBG | [AutoDuty] General Settings Active: Vnav_Align_Camera_Off, YesAlready
18:20:39.420 | DBG | [AutoDuty] Setting VnavAlignCamera: False
18:20:39.422 | DBG | [AutoDuty] Setting YesAlready Enabled: False
18:20:39.423 | DBG | [AutoDuty] SchedulerHelper - ExitDutyTimeOut Added to Scheduler
18:20:39.423 | DBG | [AutoDuty] Task ExitDuty-Invoke completed successfully
18:20:39.450 | DBG | [AutoDuty] Starting to execute task: ExitDuty-WaitExitDutyRunning
18:20:39.464 | INF | [AutoDuty] Initialized Callback module, FireCallback = 0x00007FF740993F20
18:20:41.044 | DBG | [AutoDuty] ClientState_TerritoryChanged: t=1162
18:20:41.044 | DBG | [AutoDuty] We Changed Territories but are doing after loop actions or not running at all or in a Territory not supported by AutoDuty
18:20:43.430 | DBG | [AutoDuty] SchedulerHelper - ExitDutyTimeOut Removed from Scheduler
18:20:43.431 | INF | [AutoDuty] ExitDuty Finished
18:20:43.431 | DBG | [AutoDuty] Setting VnavAlignCamera: True
18:20:43.432 | DBG | [AutoDuty] Setting YesAlready Enabled: True
18:20:43.457 | DBG | [AutoDuty] Task ExitDuty-WaitExitDutyRunning completed successfully
18:20:44.318 | DBG | [AutoDuty] SchedulerHelper - Executing action RecentlyWatchedCutsceneTimer
18:20:44.318 | DBG | [AutoDuty] SchedulerHelper - RecentlyWatchedCutsceneTimer Removed from Scheduler

Other relevant plugins installed

Altoholic v0.0.0.13 loaded. AntiAfkKick v2.1.0.6 loaded. Artisan v4.0.1.8 loaded. Auto Jail Marker v3.3.0.0 loaded. Auto Login v1.3.0.0 loaded. AutoDuty v0.0.0.169 loaded. AutoHook v4.3.0.12 loaded. Automaton v69.40 loaded. Avant-Garde v0.1.2.0 loaded. Avarice v2.1.0.4 loaded. BatteryGauge v1.2.0.0 loaded. Better borderless window mode v0.0.0.4 loaded. Better Playtime v1.4.1.0 loaded. BossMod Reborn v7.2.0.144 loaded. Brio v0.4.2 loaded. Browsingway v1.6.2 loaded. Burning Down the House v1.6.6 loaded. Burnt Toast v1.3.4.0 loaded. Cammy v2.1.0.9 loaded. Character Data Sync v2.0.0.10 loaded. Character Panel Refined v1.8.1.0 loaded. Chat 2 v1.29.3.0 loaded. Chat Bubbles v2.1.7.1 loaded. Clarity In Chaos v2.0.0.0 loaded. Clean Hunt Chat v1.0.0.0 loaded. Congratulations v1.3.0.0 loaded. Currency Tracker v1.4.4.0 loaded. Customize+ v2.0.6.2 loaded. Damage Info v2.4.0.3 loaded. Death Recap v1.12.0.0 loaded. Deliveroo v5.5 loaded. DelvUI v2.2.1.2 loaded. Directional v0.0.1.0 loaded. Discord Rich Presence v2.0.4.1 loaded. Doorbell v1.0.3.5 loaded. Dropbox v1.0.1.6 loaded. DynamicBridge v1.0.6.4 loaded. Eventy v1.0.1.0 loaded. Expanded Search Info v1.4.0 loaded. ezMiniCactpot v2.0.0.1 loaded. ezWondrousTails v3.1.0.4 loaded. FFXIV RP Event Calendar v1.0.1.4 loaded. FPS Plugin v1.7.0.0 loaded. Fungah v1.0.0.4 loaded. GatherBuddy Reborn v7.2.1.9 loaded. Glamourer v1.3.1.1 loaded. HaselTweaks v26.1.1 loaded. Heliosphere v2.3.1.0 loaded. Honorific v1.5.0.1 loaded. Hunty v1.3.1.0 loaded. IINACT v2.7.2.0 loaded. Item Vendor Location v2.7.1.0 loaded. Ktisis v0.3.1 loaded. LazyLoot v5.3.0.2 loaded. Lifestream v2.3.0.0 loaded. Macro Chain Redux v2.1.1.1 loaded. MakePlace Plugin v3.6.2 loaded. Mare Synchronos v0.10.10 loaded. Market board v1.8.0.0 loaded. Marketbuddy v0.2.3.1 loaded. Mini v2.1.0.3 loaded. Mini-Mappingway v1.0.0.7 loaded. Moodles v1.0.0.27 loaded. MultiHit v0.0.1.0 loaded. Namingway v1.1.14.0 loaded. Neko Fans v1.3.3 loaded. Neko Fans NSFW 18+ Patch v1.0.6 loaded. NoSoliciting v3.1.0.0 loaded. NoTankYou v7.1.0.0 loaded. Orchestrion Plugin v2.2.0.7 loaded. Palace Pal v4.10.0.0 loaded. Pandora's Box v1.6.1.0 loaded. PartyPlanner v1.6.2.0 loaded. Pat Me v1.10.1.0 loaded. Peeping Tom v1.7.17 loaded. Penumbra v1.2.1.5 loaded. Pet Nicknames v2.2.0.4 loaded. PingPlugin v2.7.0.0 loaded. PlayerTrack v3.4.7.0 loaded. Portrait Fixer v1.0.0.9 loaded. Price Insight v2.11.0.0 loaded. Puppet Master v7.0.5.7 loaded. QoL Bar v2.3.3.0 loaded. QuestAWAY v2.0.0.5 loaded. Questionable v3.7 loaded. ReAction v1.3.3.10 loaded. Ready Check Helper v1.0.7.5 loaded. Resizable HUD v1.3.0.0 loaded. ResLogger2.Plugin v0.0.2.6 loaded. RezPls v1.3.0.1 loaded. Rotation Solver Reborn v7.0.5.134 loaded. RTyping v0.1.0.4 loaded. Saucy v1.4.0.3 loaded. Say What? v1.0.2.4 loaded. Seated Sidekick Spectator v0.1.1.0 loaded. Simple Heels v0.10.1.1 loaded. Simple Tweaks Plugin v1.10.3.0 loaded. SimpleCompare v2.0.0.3 loaded. SkipCutscene v3.0.0.0 loaded. Sonar v0.6.6.0 loaded. Splatoon v3.7.1.1 loaded. Teleporter v2.0.2.4 loaded. TextAdvance v3.2.3.7 loaded. The Great Controller HUD Switcher v1.0.1.2 loaded. Tidy Chat v2.0.5.0 loaded. TinyCommands v8.9.1 loaded. Title Edit v3.0.1.2 loaded. Tourist v1.2.15 loaded. Umbra XIV v2.2.36.0 loaded. V(ery) Island v0.0.0.120 loaded. VFXEditor v1.9.0.7 loaded. Visibility v1.1.7.5 loaded. vnavmesh v0.0.0.41 loaded. Waitingway v2.2.0.0 loaded. Weatherman v2.4.1.0 loaded. Who Did That? v1.6.1.0 loaded. Who's Talking v0.8.0.0 loaded. Wholist v1.5.0.0 loaded. WoLua v3.7.0 loaded. Workshoppa v6.2 loaded. XIV Instant Messenger v1.4.0.8 loaded. XIVSlothCombo v3.2.0.8 loaded. Yes Already v1.8.0 loaded.

Plugin config file

AutoDuty.json I have a video clip of it leaving early and the full dalamud.log, if for whatever reason that helps you. I can send over privately upon request (worried about sensitive info)

MillerTheBest commented 2 weeks ago

I noticed the same in other instances too. This wasted a couple of hours of mine until I realised no item was received because the dungeons were never finished before leaving and restarting the next. This is one of many reasons I have stayed away from the updates in recent weeks and I have been running old versions locally instead.

Herculezz55 commented 2 weeks ago

I noticed the same in other instances too. This wasted a couple of hours of mine until I realised no item was received because the dungeons were never finished before leaving and restarting the next. This is one of many reasons I have stayed away from the updates in recent weeks and I have been running old versions locally instead.

if you would be so kinds as to share said instances, I unfortunately cannot read minds :(

Herculezz55 commented 2 weeks ago

What happened?

I was using AutoDuty to clear Lunar Subterrane with Duty Support when right before reaching the final boss, AutoDuty decided to leave prematurely, without defeating the final boss

Version Number

0.0.0.169

Steps to reproduce the error

afaik just enter Lunar Subterrane with Duty Support

Relevant log output

18:20:26.909 | DBG | [AutoDuty] Stage=Moving
18:20:34.130 | DBG | [AutoDuty] SchedulerHelper - RecentlyWatchedCutsceneTimer Added to Scheduler
18:20:39.148 | DBG | [AutoDuty] SchedulerHelper - Executing action RecentlyWatchedCutsceneTimer
18:20:39.148 | DBG | [AutoDuty] SchedulerHelper - RecentlyWatchedCutsceneTimer Removed from Scheduler
18:20:39.321 | DBG | [AutoDuty] SchedulerHelper - RecentlyWatchedCutsceneTimer Added to Scheduler
18:20:39.329 | DBG | [AutoDuty] Stage=Reading Path
18:20:39.382 | DBG | [AutoDuty] Starting to execute task: ExitDuty-Invoke
18:20:39.413 | INF | [AutoDuty] ExitDuty Started
18:20:39.420 | DBG | [AutoDuty] General Settings Active: Vnav_Align_Camera_Off, YesAlready
18:20:39.420 | DBG | [AutoDuty] Setting VnavAlignCamera: False
18:20:39.422 | DBG | [AutoDuty] Setting YesAlready Enabled: False
18:20:39.423 | DBG | [AutoDuty] SchedulerHelper - ExitDutyTimeOut Added to Scheduler
18:20:39.423 | DBG | [AutoDuty] Task ExitDuty-Invoke completed successfully
18:20:39.450 | DBG | [AutoDuty] Starting to execute task: ExitDuty-WaitExitDutyRunning
18:20:39.464 | INF | [AutoDuty] Initialized Callback module, FireCallback = 0x00007FF740993F20
18:20:41.044 | DBG | [AutoDuty] ClientState_TerritoryChanged: t=1162
18:20:41.044 | DBG | [AutoDuty] We Changed Territories but are doing after loop actions or not running at all or in a Territory not supported by AutoDuty
18:20:43.430 | DBG | [AutoDuty] SchedulerHelper - ExitDutyTimeOut Removed from Scheduler
18:20:43.431 | INF | [AutoDuty] ExitDuty Finished
18:20:43.431 | DBG | [AutoDuty] Setting VnavAlignCamera: True
18:20:43.432 | DBG | [AutoDuty] Setting YesAlready Enabled: True
18:20:43.457 | DBG | [AutoDuty] Task ExitDuty-WaitExitDutyRunning completed successfully
18:20:44.318 | DBG | [AutoDuty] SchedulerHelper - Executing action RecentlyWatchedCutsceneTimer
18:20:44.318 | DBG | [AutoDuty] SchedulerHelper - RecentlyWatchedCutsceneTimer Removed from Scheduler

Other relevant plugins installed

Altoholic v0.0.0.13 loaded. AntiAfkKick v2.1.0.6 loaded. Artisan v4.0.1.8 loaded. Auto Jail Marker v3.3.0.0 loaded. Auto Login v1.3.0.0 loaded. AutoDuty v0.0.0.169 loaded. AutoHook v4.3.0.12 loaded. Automaton v69.40 loaded. Avant-Garde v0.1.2.0 loaded. Avarice v2.1.0.4 loaded. BatteryGauge v1.2.0.0 loaded. Better borderless window mode v0.0.0.4 loaded. Better Playtime v1.4.1.0 loaded. BossMod Reborn v7.2.0.144 loaded. Brio v0.4.2 loaded. Browsingway v1.6.2 loaded. Burning Down the House v1.6.6 loaded. Burnt Toast v1.3.4.0 loaded. Cammy v2.1.0.9 loaded. Character Data Sync v2.0.0.10 loaded. Character Panel Refined v1.8.1.0 loaded. Chat 2 v1.29.3.0 loaded. Chat Bubbles v2.1.7.1 loaded. Clarity In Chaos v2.0.0.0 loaded. Clean Hunt Chat v1.0.0.0 loaded. Congratulations v1.3.0.0 loaded. Currency Tracker v1.4.4.0 loaded. Customize+ v2.0.6.2 loaded. Damage Info v2.4.0.3 loaded. Death Recap v1.12.0.0 loaded. Deliveroo v5.5 loaded. DelvUI v2.2.1.2 loaded. Directional v0.0.1.0 loaded. Discord Rich Presence v2.0.4.1 loaded. Doorbell v1.0.3.5 loaded. Dropbox v1.0.1.6 loaded. DynamicBridge v1.0.6.4 loaded. Eventy v1.0.1.0 loaded. Expanded Search Info v1.4.0 loaded. ezMiniCactpot v2.0.0.1 loaded. ezWondrousTails v3.1.0.4 loaded. FFXIV RP Event Calendar v1.0.1.4 loaded. FPS Plugin v1.7.0.0 loaded. Fungah v1.0.0.4 loaded. GatherBuddy Reborn v7.2.1.9 loaded. Glamourer v1.3.1.1 loaded. HaselTweaks v26.1.1 loaded. Heliosphere v2.3.1.0 loaded. Honorific v1.5.0.1 loaded. Hunty v1.3.1.0 loaded. IINACT v2.7.2.0 loaded. Item Vendor Location v2.7.1.0 loaded. Ktisis v0.3.1 loaded. LazyLoot v5.3.0.2 loaded. Lifestream v2.3.0.0 loaded. Macro Chain Redux v2.1.1.1 loaded. MakePlace Plugin v3.6.2 loaded. Mare Synchronos v0.10.10 loaded. Market board v1.8.0.0 loaded. Marketbuddy v0.2.3.1 loaded. Mini v2.1.0.3 loaded. Mini-Mappingway v1.0.0.7 loaded. Moodles v1.0.0.27 loaded. MultiHit v0.0.1.0 loaded. Namingway v1.1.14.0 loaded. Neko Fans v1.3.3 loaded. Neko Fans NSFW 18+ Patch v1.0.6 loaded. NoSoliciting v3.1.0.0 loaded. NoTankYou v7.1.0.0 loaded. Orchestrion Plugin v2.2.0.7 loaded. Palace Pal v4.10.0.0 loaded. Pandora's Box v1.6.1.0 loaded. PartyPlanner v1.6.2.0 loaded. Pat Me v1.10.1.0 loaded. Peeping Tom v1.7.17 loaded. Penumbra v1.2.1.5 loaded. Pet Nicknames v2.2.0.4 loaded. PingPlugin v2.7.0.0 loaded. PlayerTrack v3.4.7.0 loaded. Portrait Fixer v1.0.0.9 loaded. Price Insight v2.11.0.0 loaded. Puppet Master v7.0.5.7 loaded. QoL Bar v2.3.3.0 loaded. QuestAWAY v2.0.0.5 loaded. Questionable v3.7 loaded. ReAction v1.3.3.10 loaded. Ready Check Helper v1.0.7.5 loaded. Resizable HUD v1.3.0.0 loaded. ResLogger2.Plugin v0.0.2.6 loaded. RezPls v1.3.0.1 loaded. Rotation Solver Reborn v7.0.5.134 loaded. RTyping v0.1.0.4 loaded. Saucy v1.4.0.3 loaded. Say What? v1.0.2.4 loaded. Seated Sidekick Spectator v0.1.1.0 loaded. Simple Heels v0.10.1.1 loaded. Simple Tweaks Plugin v1.10.3.0 loaded. SimpleCompare v2.0.0.3 loaded. SkipCutscene v3.0.0.0 loaded. Sonar v0.6.6.0 loaded. Splatoon v3.7.1.1 loaded. Teleporter v2.0.2.4 loaded. TextAdvance v3.2.3.7 loaded. The Great Controller HUD Switcher v1.0.1.2 loaded. Tidy Chat v2.0.5.0 loaded. TinyCommands v8.9.1 loaded. Title Edit v3.0.1.2 loaded. Tourist v1.2.15 loaded. Umbra XIV v2.2.36.0 loaded. V(ery) Island v0.0.0.120 loaded. VFXEditor v1.9.0.7 loaded. Visibility v1.1.7.5 loaded. vnavmesh v0.0.0.41 loaded. Waitingway v2.2.0.0 loaded. Weatherman v2.4.1.0 loaded. Who Did That? v1.6.1.0 loaded. Who's Talking v0.8.0.0 loaded. Wholist v1.5.0.0 loaded. WoLua v3.7.0 loaded. Workshoppa v6.2 loaded. XIV Instant Messenger v1.4.0.8 loaded. XIVSlothCombo v3.2.0.8 loaded. Yes Already v1.8.0 loaded.

Plugin config file

AutoDuty.json I have a video clip of it leaving early and the full dalamud.log, if for whatever reason that helps you. I can send over privately upon request (worried about sensitive info)

I won't be able to check into this until i have this zone unlocked

MillerTheBest commented 2 weeks ago

I noticed the same in other instances too. This wasted a couple of hours of mine until I realised no item was received because the dungeons were never finished before leaving and restarting the next. This is one of many reasons I have stayed away from the updates in recent weeks and I have been running old versions locally instead.

if you would be so kinds as to share said instances, I unfortunately cannot read minds :(

Hi, I didn't mention the instance names because I don't think it's an instance-relevant issue, nor a faulty path for an instance. The two instances that I'm sure of are Lunar Subterrane and The Ghimlyt Dark, especially the latter.

I've never actually watched what happened in Lunar Subterrane, but I agree that the final boss wasn't reached because I can see the tome of killing the final boss wasn't received.

What kept happening in The Ghimlyt Dark is that: The character needs to jump down from a cliff before entering the final arena of the final boss. I witnessed that - a. the character approached the cliff, b. scene transition happened c. AD exits the instance while the character was falling down from the cliff into the final arena (the existing happens during falling). So, the final boss wasn't reached, the instance didn't finish, but AD decided to quit and start the next loop. This doesn't happen on the 1st run of the loop, meaning the 1st run can finish. However, every run after fails, until you manually stop AD and restart the run.

The reason that I said it's not instance/path relevant is because I re-wrote the path for The Ghimlyt Dark by using 'Build' (the existing one doesn't open chests and can get stuck when mobs are far). I also changed the final boss position in the path, added wait for combat, and added moveto another spot after boss fight, to make sure the fight finishes. However, the final boss fight never started.

I've tried this on the current and recent AD versions, as well as version 160. I thought 160 was stable due to other reasons, but no, this problem repeats on 160 too.

So, without reading the actual code, my best guess is: how AD decides to exit an instance is broken. Either AD doesn't check the progress of the instance (or maybe Dalamud doesn't provide that info). Or AD's decision making for when to exit an instance is broken. I know that 'quitting' an instance is faster, but maybe it's safer to exist by walking to the 'exist' and click on it. After all, you are not wasting a couple more seconds. I haven't tried this bit but from memory AD doesn't want to click on 'exit'.

For Lunar, I think the problem started before 'last week', meaning before this post initially started. But Lunar didn't bother me too much. I think The Ghimlyt Dark was fine before 3rd of October, but I wasn't 100% sure of the dates. I had problems with The Ghimlyt Dark since 6th of October (my local time last night).

At last, I tried to turn off 'Auto Leave Duty' in config settings, but no, AD still quits when the character was falling.

Hope this helps.