search

ffxx68 / Sharp_ce140f_emul

13 stars 2 forks source link

Cannot give 8-character filename #1

Closed ht-deko closed 1 year ago

ht-deko commented 1 year ago

If an 8-character filename is used, the SAVE command will fail to execute. It seems to be caused by the small buffer size of FileName defined in commands.cpp.

// locals
uint8_t  out_checksum = 0;
FILE    *fp;
int      fileCount; 
uint8_t  FileName[17]; // [15] -> [17]
int      file_size;
int      file_pos = 0;
ffxx68 commented 1 year ago

Thanks for the pointer! I'm curious - where are you testing this code on? Have you built a board yourself, by chance?

ht-deko commented 1 year ago

I am testing on a CE-140F emulator built on a breadboard. https://ht-deko.com/pokecom/ce140f_emu.html

ffxx68 commented 1 year ago

Great ! I'm glad to see you have managed to reproduce the project, and fix some bugs as well !

Il giorno gio 23 mar 2023 alle ore 03:10 DEKO @.***> ha scritto:

I am testing on a CE-140F emulator built on a breadboard. https://ht-deko.com/pokecom/ce140f_emu.html

— Reply to this email directly, view it on GitHub https://github.com/ffxx68/Sharp_ce140f_emul/issues/1#issuecomment-1480482984, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFBAZPUEPWFKNLNCXILTXDW5OWKTANCNFSM6AAAAAAVPUWJVY . You are receiving this because you commented.Message ID: @.***>