search

fgRuslan / BooruDownloader

Gelbooru and Danbooru downloader
https://fgruslan.github.io/BooruDownloader
39 stars 2 forks source link

Simplification of Dectector #4

Closed ShujianDou closed 3 years ago

ShujianDou commented 3 years ago

I don't know if it works, since I haven't tested it; however, I believe this is a much better way of doing this.

ShujianDou commented 3 years ago

Todo: make it work with http/https links. (Forgot to add)

fgRuslan commented 3 years ago

Wow. If you do this, I will be glad :)

Also, do you have any info on what websites should I add to gelbooru group or danbooru group? I think that engine detection feature is not good enough until it has a bigger list of websites.

ShujianDou commented 3 years ago

Hmm, I don't really know what other websites you could add, but any site hosting images should work, for example HAnime and similar sites that allow uploading of images. Also, I'm not too familiar with the terms gelbooru or danbooru.

fgRuslan commented 3 years ago

gelbooru and danbooru are engines for such websites that has anime (and hentai :) ) pictures

ShujianDou commented 3 years ago

Ah, ic; that sounds cool. Well, I'll complete this pull request later today for your review.

fgRuslan commented 3 years ago

Thank youuu!

ShujianDou commented 3 years ago

should now work regardless of if it is a url with http or https, and np! I love projects like these; I plan on integrating your concept of downloading images w/ metadata into my own project, which does not support downloading images from sites (unless it's part of a manga) for the moment.